linbox icon indicating copy to clipboard operation
linbox copied to clipboard

Clean LinboxError/LinBoxError

Open Breush opened this issue 5 years ago • 1 comments

Two different general errors exist within linbox and they are both used:

  • linbox/util/debug.h: class LinBoxError (which inherits from NotImplementedYet)
  • linbox/util/error.h: class LinboxError (declined to things like LinboxMathInconsistentSystem)

Which one to keep?

About errors' use cases, it looks like we need:

  • LinBoxError (or some generic error)
  • PreconditionFailed
  • NotImplementedYet
  • InvalidInput (for readers)
  • InconsistentSystem but others are left unused (LinboxMathDivZero, LinBoxFailure, ...)

Moreover, while cleaning, in debug.h it looks like there is a concept of Exception (BadInputException, LINBOX_RAISE_EXCEPTION etc.) that is never used.

Breush avatar Mar 04 '19 08:03 Breush

SolveFailed should also be considered when addressing this issue

ClementPernet avatar Mar 20 '19 14:03 ClementPernet