linbox
linbox copied to clipboard
Compose Blackbox
Working on #159, I found a weird thing about the Compose blackbox in blackbox/compose.h file.
There is a specialisation of Compose when the two composed blackboxes share the same type. The only reason of such a specialisation is to handle the construction of a multi-composed blackbox that is build upon a bunch of blackboxes given in a vector. Of course, rhis makes the code more complex (e.g. blackboxes are kept through vector of pointers).
I have not found any instances of such a construction in LinBox. Therefore, I doubt about the usefulness of this specialisation, which by the say makes the code less efficient for only two blackboxes If no one object I will drop off this specialisation.
I could not find any usage of it. If your think there is no reason to keep it (e.g. it slows down a 2 args compose) then drop it!