linbox icon indicating copy to clipboard operation
linbox copied to clipboard

Are we using C++14?

Open dsroche opened this issue 6 years ago • 3 comments

The most recent commit to master (0bb747ae) has an enable_if_t, which is causing me some compilation errors. I believe that helper struct is only part of C++14, but it seems that the default compiler flag in Linbox is g++11.

So what should it be? Personally I would be happy for C++14; the compiler support for clang and g++ seems to be pretty stable and it's not a big change from C++11 as far as I know, mostly just some useful help (such as auto return types hooray!). Or if it's only C++11, I guess the enable_if_t is a bug.

dsroche avatar Jul 03 '18 19:07 dsroche

This is no more an issue thanks to #127. But the question remains open. I am in favor of supporting C++14, but this is not yet possible for Sage.

jgdumas avatar Jul 05 '18 15:07 jgdumas

@jgdumas What makes it not to be possible for Sage? We might be able to use C++14 internally but show a C++11 interface.

Breush avatar Sep 03 '18 14:09 Breush

@Breush : not really, as SageMath uses LinBox as a source code library and compiles it, so we should require SageMath to use all the flags required to compile LinBox, including --std=c++14. I'll raise the question on sage-devel about whether or not this seems reasonable to move to c++14.

ClementPernet avatar Sep 03 '18 14:09 ClementPernet