tmail-flutter icon indicating copy to clipboard operation
tmail-flutter copied to clipboard

Published 20 hours ago • verified publisher icon linagora

[FIX] Some actions are not working when `Semantics` enabled

Open dab246 opened this issue 1 year ago • 32 comments

Issue related

#2977

Action affected

  1. Advanced Search
  • [x] Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions
  • [x] Overlap suggestion view with advanced search view
  • [x] Advanced search view auto closed when click any field
  • [x] (CHROME) Has attachment check-box still lost focus (click on it, but the view below got the click)
  • [x] Advanced search dialog view cannot be closed when click advanced search icon
  • [x] Select all button is clicked, even advanced search stay overlays
  • [x] Select, Mark as read, Starred button is clicked in item email, even advanced search stay overlays
  • [x] Has Attachment, All time, From button is clicked, even advanced search or suggestion search view stay overlays
  • [ ] Open quick search dialog, select in quick chip: From me , Last 7 days or Has attachment, after that we can not input text in quick search
  1. App Grid
  • [x] Cannot click item in app grid
  1. Mailbox Creator
  • [x] Text field not focus when click
  1. Popup Menu
  • [x] Cannot click item
  1. Dropdown Menu
  • [x] Cannot click item
  1. Composer
  • [x] Lost editor focus
  • [x] Lost subject focus
  • [x] Cannot click bottom option (RichText, Send, Draft,...)
  • [x] Focus of body composer is lost after change font family
  • [x] Focus indicator still display, but can not fill text in composer body after change color background
  1. Rename Mailbox
  • [x] Text Field missing focus
  1. Contact view
  • [x] Text field not focus when click
  • [x] Duplicate open Contact View
  1. Sort By
  • [x] Cannot click item
  1. Language
  • [x] Cannot change language
  1. Forward View
  • [x] Input field lost focus when clicked
  1. Vacation View
  • [x] Subject field cannot focus when clicked
  • [x] Can not select time in vacation
  • [x] Can not select text color in vacation form
  • [x] Paragraph dialog & Order list dialog open twice and cannot be closed
  1. Search Mailbox, Email View
  • [x] Text field not focus when click
  • [x] Can not use delete button in keyboard in search bar for folder if user not click on this one more time
  1. Rich Text Toolbar
  • [x] Text color dialog opens twice
  • [x] Paragraph dialog & Order list dialog open twice and cannot be closed
  1. PDF Viewer
  • [x] When I click to open PDF in list, list is closed
  1. Rule Filter
  • [x] Focus is totally lost in quick form of creating email rule

Flutter Issue Related

  • https://github.com/flutter/flutter/issues/150020
  • https://github.com/flutter/flutter/issues/149001
  • https://github.com/flutter/flutter/issues/129324
  • https://github.com/flutter/flutter/issues/141975

dab246 avatar Aug 14 '24 12:08 dab246

This PR has been deployed to https://linagora.github.io/tmail-flutter/3086.

github-actions[bot] avatar Aug 14 '24 12:08 github-actions[bot]

  • [x] Adr for semantic

hoangdat avatar Aug 19 '24 03:08 hoangdat

  • [x] composer: lost focus when click onetime 🔥 🔥 🔥

hoangdat avatar Aug 19 '24 03:08 hoangdat

Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions

Please check again Env: preprod Build mode: profile

https://github.com/user-attachments/assets/733903b7-4b7b-4efd-aebd-7089fd94af5d

tddang-linagora avatar Aug 27 '24 03:08 tddang-linagora

Composer

Env: preprod Build mode: profile

  • [x] Text color dialog opens twice

https://github.com/user-attachments/assets/292fa10f-616e-49c4-b4a6-68f31a660ea4

  • [x] Paragraph dialog & Order list dialog open twice and cannot be closed

https://github.com/user-attachments/assets/c4ad5b22-6a04-43dc-9606-a2da776e428b

https://github.com/user-attachments/assets/0a1789bb-1faf-4218-b1b7-5929d2be966b

tddang-linagora avatar Aug 27 '24 04:08 tddang-linagora

Text color dialog opens twice Paragraph dialog & Order list dialog open twice and cannot be closed

Also happens in identity editor

tddang-linagora avatar Aug 27 '24 04:08 tddang-linagora

  • [x] (CHROME) Has attachment check-box still lost focus (click on it, but the view below got the click) image

hoangdat avatar Aug 27 '24 07:08 hoangdat

  • [x] should be rebased your fix and all related stuff of semantic with refactor (no need playwright's stuffs)

hoangdat avatar Aug 27 '24 07:08 hoangdat

  • [x] can not use delete button in keyboard in search bar for folder if user not click on this one more time

https://github.com/user-attachments/assets/f588756a-cd63-48cf-aa2d-44b9c9bd68c4

hoangdat avatar Aug 27 '24 07:08 hoangdat

  • [x] can not expand sub folder in Mailbox View image

hoangdat avatar Aug 27 '24 07:08 hoangdat

  • [x] when I click to open pdf in list, list is closed

https://github.com/user-attachments/assets/5d1e36b2-24f7-49b1-b7a2-011ccb8b128d

hoangdat avatar Aug 27 '24 08:08 hoangdat

  • [x] Text color dialog opens twice

https://github.com/user-attachments/assets/e29b1ee4-d961-4cc9-bb52-742f54f7d3a0

  • [x] Paragraph dialog & Order list dialog open twice and cannot be closed

https://github.com/user-attachments/assets/72d5cf59-31d2-4d5d-9dfa-ad55faaae1dc

  • [x] (CHROME) Has attachment check-box still lost focus (click on it, but the view below got the click)

https://github.com/user-attachments/assets/7a35f552-d1a2-42cd-822d-62a31ec138e6

  • [x] can not use delete button in keyboard in search bar for folder if user not click on this one more time

https://github.com/user-attachments/assets/e0cba6a1-e1c8-4098-8246-d4c9841ab164

  • [x] should be rebased your fix and all related stuff of semantic with refactor (no need playwright's stuffs)
  • [x] when I click to open pdf in list, list is closed

https://github.com/user-attachments/assets/6a9a6e8b-6fdf-4487-b668-f411564b894c

dab246 avatar Aug 28 '24 13:08 dab246

  • [x] Can not expand sub folder in Mailbox View

https://github.com/user-attachments/assets/34b5fc36-e28a-4339-beb0-736766475cee

dab246 avatar Aug 29 '24 03:08 dab246

  • [x] Advanced Search dialog cannot be closed when click advanced search icon

https://github.com/user-attachments/assets/4cb1c87f-b2cd-420b-a01a-d3c46a536bf0

dab246 avatar Aug 29 '24 03:08 dab246

  • [x] Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions

https://github.com/user-attachments/assets/aa70a703-07c9-47e2-abd2-d638b5cfb1b2

dab246 avatar Aug 29 '24 06:08 dab246

Will this be reviewed one day ? nearby future maybe?

jay-athelas avatar Sep 03 '24 15:09 jay-athelas

hi @jay-athelas it is still in progress. We need to test the whole app carefully. All the components, widgets need to test. Can you also take a look and helf us on it?

hoangdat avatar Sep 04 '24 01:09 hoangdat

@hoangdat I have tested the app, do you perhaps have a timeframe when will this fix be released?

Xola11 avatar Sep 04 '24 08:09 Xola11

  • [x] select all button is clicked, even advanced search stay overlays

https://github.com/user-attachments/assets/06ac8770-1d7a-44ea-a889-c0840e9b4fd6

hoangdat avatar Sep 23 '24 04:09 hoangdat

  • [x] Open quick search dialog, select in quick chip: From me Last 7 days or Has attachment, after that we can not input text in quick search
  1. open quick search
  2. select From me
  3. try to typing in keyboard, text is not filled in quick search

https://github.com/user-attachments/assets/51c827da-8041-4590-812b-226f671a9183

hoangdat avatar Sep 23 '24 04:09 hoangdat

  • [x] focus is totally lost in quick form of creating email rule

https://github.com/user-attachments/assets/1ad13bbe-a3aa-4a37-8e10-4df0503c04e3

hoangdat avatar Sep 23 '24 04:09 hoangdat

  • [x] focus of body composer is lost after change font family
  • [x] focus indicator still display, but can not fill text in composer body after change color background
  • [x] use tab to change focus but focus is never go to body of composer

hoangdat avatar Sep 23 '24 05:09 hoangdat

  • [x] can not select time in vacation

https://github.com/user-attachments/assets/0b7f1130-b1c6-4f95-9c48-d04cc865e0ae

hoangdat avatar Sep 23 '24 07:09 hoangdat

  • [x] can not select text color in vacation form

https://github.com/user-attachments/assets/5c59583b-a03b-42ad-ac44-eb59a14b54e1

hoangdat avatar Sep 23 '24 07:09 hoangdat

  • [x] focus is totally lost in quick form of creating email rule

Screen.Recording.2024-09-23.at.11.56.24.mov

Fixed.

https://github.com/user-attachments/assets/8546c0c0-7221-4855-944e-57e281382601

dab246 avatar Sep 26 '24 06:09 dab246

  • [X] can not select text color in vacation form

Screen.Recording.2024-09-23.at.14.43.33.mov

Fixed

https://github.com/user-attachments/assets/5ec9198e-340c-4873-8db6-e8c245d13252

dab246 avatar Sep 30 '24 10:09 dab246

  • [x] can not select time in vacation

Screen.Recording.2024-09-23.at.14.28.32.mov

Fixed

https://github.com/user-attachments/assets/12f5ed8b-9473-4d06-8e68-bfcd0ace0930

dab246 avatar Sep 30 '24 10:09 dab246

  • [x] use tab to change focus but focus is never go to body of composer

Need merged

https://github.com/linagora/html-editor-enhanced/pull/46

Resolved

https://github.com/user-attachments/assets/39b9b91e-8992-4027-a19a-8f4dfb1de8aa

dab246 avatar Sep 30 '24 10:09 dab246

  • [x] select all button is clicked, even advanced search stay overlays

Screen.Recording.2024-09-23.at.11.26.26.mov

Fixed

https://github.com/user-attachments/assets/be0e236f-8c2c-4b03-b668-df707cd52a1c

dab246 avatar Oct 01 '24 03:10 dab246

  • [x] focus of body composer is lost after change font family

Focus is not lost, only cursor indicator is lost, we can still enter text. This error is related to the summernote library being used. There is currently no solution to fix it. Follow issue summernote-issues#4697

https://github.com/user-attachments/assets/b0cd3a35-41b1-4a29-b2ac-6616c1a03d83

  • [x] focus indicator still display, but can not fill text in composer body after change color background

Fixed

https://github.com/user-attachments/assets/da5cd82e-0eb0-40ec-9fb2-fe8a6eb761a5

dab246 avatar Oct 02 '24 05:10 dab246