tmail-flutter icon indicating copy to clipboard operation
tmail-flutter copied to clipboard
verified publisher icon linagora

[Improvement] No need to suggest sending message to drafts when it's empty

Open tprudentova opened this issue 1 year ago • 4 comments

0.12.1 tested on Android, Firefox, Safari, Opera; mail.stg.lin-saas.com

  1. Open composer
  2. Click Close
  3. There's a suggestion to save email to Drafts. I believe it's not necessary when the user hasn't input anything in the composer

https://github.com/user-attachments/assets/f4226526-1c4b-4ea5-a4b3-fd9545ecd9ec

tprudentova avatar Jul 24 '24 11:07 tprudentova

hi @dab246, how we can distinguish the case of it? we should to consider carefully the signature in draft too

hoangdat avatar Jul 26 '24 05:07 hoangdat

hi @dab246, how we can distinguish the case of it? we should to consider carefully the signature in draft too

  • When doing Save As Draft. We should update the value of EmailActionType=editDraft. Moreover, we also have the function validateEmailChange to check if the email has changed or not. So we can handle this case.

dab246 avatar Jul 26 '24 07:07 dab246

  • Case 1: new composer
  • Case 2: edit draft

Should add logic to compare identity to validate changes.

hoangdat avatar Aug 28 '24 03:08 hoangdat

Also fixed at https://github.com/linagora/tmail-flutter/pull/3184

dab246 avatar Oct 04 '24 03:10 dab246