tmail-flutter icon indicating copy to clipboard operation
tmail-flutter copied to clipboard

Published 20 hours ago • verified publisher icon linagora

TF-2602 Fix charset is not set when I attach a `text/plain` attachment

Open dab246 opened this issue 1 year ago • 5 comments

Issue

#2602

Solution

Use flutter_charset_detector to detect charset of the text file.

Demo

https://github.com/linagora/tmail-flutter/assets/80730648/ea3daaaa-cf46-44a2-ac93-24c49408d8d2

Log

Screenshot 2024-02-26 at 13 16 24

Related

We can review this PR to help it quickly merge

  • https://github.com/amake/flutter_charset_detector/pull/6

dab246 avatar Feb 23 '24 09:02 dab246

This PR has been deployed to https://linagora.github.io/tmail-flutter/2634.

github-actions[bot] avatar Feb 23 '24 09:02 github-actions[bot]

Hi BE team cc @chibenwa @quantranhong1999 , I found a problem:

Desc:

  1. I have set charset for attachment files with mimeType=text/plain when sending emails and it was successful.
  2. But when opening the received email, in the attachment the charset attribute is set by the jmap server to default us-ascii.
  • Payload Email/set:
307682918-0070fe97-43c7-4e0a-b86d-ac8c0309a618
  • Response Email/get

Screenshot 2024-02-29 at 14 12 07

Question:

Is it wrong if I pass charset like that?. Does the server accept attachment charset changes?

dab246 avatar Feb 29 '24 07:02 dab246

The contentype shall be specified when uploading the blob:

Request method:	POST
Request URI:	http://localhost:34833/upload/29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6
Proxy:			<none>
Request params:	<none>
Query params:	<none>
Form params:	<none>
Path params:	<none>
Headers:		accept=application/json; jmapVersion=rfc-8621
				Content-Type=text/plain; charset=US_ASCII
Cookies:		<none>
Multiparts:		<none>
Body:
[49, 50, 51, 52, 53, 54, 55, 56, 57, 13, 10...


Likely the Email/set charset should be able to override the one of the upload though...

chibenwa avatar Mar 04 '24 06:03 chibenwa

https://github.com/apache/james-project/pull/2081

chibenwa avatar Mar 04 '24 07:03 chibenwa

  • Tested again and it is working well on preprod server after BE release.
  • We should review and merge it @hoangdat

https://github.com/linagora/tmail-flutter/assets/80730648/1fafba55-7e59-4dc9-9755-bdba67ca558c

dab246 avatar Mar 19 '24 01:03 dab246

@dab246 Should this PR be rebased to refactor or we can review it at current state?

tddang-linagora avatar Sep 04 '24 03:09 tddang-linagora

@dab246 Should this PR be rebased to refactor or we can review it at current state?

Rebase on refactor. Please review again.

dab246 avatar Sep 04 '24 05:09 dab246

  • [x] @dab246 please rebase and verify Memory leak for this PR. Please check it in both mobile and web.

hoangdat avatar Sep 17 '24 03:09 hoangdat

  • [x] @dab246 please rebase and verify Memory leak for this PR. Please check it in both mobile and web.

Memory leak

No leak

  • Web:

https://github.com/user-attachments/assets/c4712777-6f9d-44b5-88da-587da1f3f5a0

  • Mobile:

https://github.com/user-attachments/assets/9b131bc0-a449-4e4b-96e2-9ff61f15b65d

dab246 avatar Sep 17 '24 08:09 dab246