Lina Butler

Results 19 comments of Lina Butler

This would be nifty to have! Swift handles this [a little differently](https://docs.swift.org/swift-book/LanguageGuide/AccessControl.html#ID519)—when you use `@testable import` to import a library, you get access to any internal (though not private or...

Love your summary (and your format of documenting "here's pointers to what we learned the last time we tried this"—totally gonna steal that)! The Gecko stuff always felt like a...

That sounds great! We could always add an `Owned` or `ByVal` (to match `ByRef`) annotation or something if a Rust function needs to take ownership of the sequence _and_ calling...

I guess approach four is, do nothing, and let authors figure it out when they get a compile error. While I think we could be a little more helpful (it’s...

Hi there! Could you please post the error you're seeing?

Hi @PARAIPAN9! I'm so sorry I didn't see your PR go by, but we actually don't want to show sponsored or non-sponsored Firefox Suggest suggestions in private browsing—even if the...

Hi @petruSt24, thanks so much for doing this! 👋🏼 In case it helps, I added "engagement events lite" (`awesomebar.engagement` and `awesomebar.abandonment`) in #18452. They're sent for the same interactions as...

@bendk Hmmm, was that comment and close meant for #6107? 😅

Thank you so much for working through all this, @bendk! I did think of [one downside for passing the full `Suggestion` to `dismiss_suggestion`](https://github.com/mozilla/application-services/pull/6147/files#r1525312121) that I should've thought of earlier, but...

Thanks for filing this! Over in https://github.com/mozilla/application-services/pull/5867#pullrequestreview-1676696796, @ncloudioj was just commenting how nice it would have been to pass a bitset instead of a `Vec` of enum variants. I think...