Kenneth Lim
Kenneth Lim
`isGraphics` or `this instanceof p5.Graphics` can both work depending on what's needed, in some cases it can be refactor into getting members from `p5.Graphics._renderer` or from the `p5` instance instead,...
Sounds like a very good plan overall, a few extra points: > At a high level, I want all entrypoints into WebGL mode to be in RendererGL One thing that...
> Makes sense! Maybe that can be done in the same file, even if it's done in a different way, so the entrypoints are easier to find. Probably don't recommend...
@davepagurek I'm trying to fix framebuffer generated from a webgl p5.Graphics at the moment and since what I'm planning now is for p5.Graphics to be a p5 instance lite but...
I think the two fixes should fix most of the things but I'll try and make it just refers to the renderer, although there may be places where `p5.Framebuffer` itself...
There's too many blocking stuff because of it so I've refactored all classes to be by default exported. It turns out the vast majority of the don't need reference to...
Yes I'm using them in `preview` with the `p5.Graphics` `createFramebuffer()` reference example adapted to instance mode. ```js const sketch = function(p){ let myBuffer, pg, torusLayer, boxLayer; p.setup = function(){ p.createCanvas(200,...
@davepagurek The `noLights()` error will need a bigger fix in that ideally the implementation for renderer stays in the renderer, eg. `noLights()` only changes the internal states of the renderer...
> For the this._pInst.something --> this.something change, I wonder if that's something we could do with a find-and-replace just in the webgl folder? I ran find src/webgl -name "*.js" |...
@davepagurek I think I got graphics frame buffer working! Have a try and see if it works for you as well?