webgui
webgui copied to clipboard
limetech
Network info display improvements
This PR aims to improve how networks are displayed for docker containers.
- fix where network ID instead of a name is displayed (generally for docker compose created containers).
- display multiple networks and the associated IP for each
Do you have a screenshot when multiple networks are displayed? (wondering how that looks like)
is it possible to test the fix before the release? I'm waiting for this very long... If I just have to swap a file, that's great. Thx
is it possible to test the fix before the release? I'm waiting for this very long... If I just have to swap a file, that's great. Thx
Yes. Edit the webui files on your server as per the commits above.
Easiest way to do this is to use vscode with the sftp plugin as per the unraid GUI Git recommendations. Or you can SSH/terminal into your unraid and use nano - but this is more prone to typos.
I'm away from my PC this week so can't give much more detail. Let me know how you get on.
I fixed the problem by swapping the DockerClient.php. Thanks a lot for this. Is it also mandatory to swap the DockerContainers.php? Thx
I fixed the problem by swapping the DockerClient.php. Thanks a lot for this. Is it also mandatory to swap the DockerContainers.php? Thx
Yes. You need to swap both
It looks like docker ports that aren't mapped are showing that they are:
e.g. these all use 7001 internally but don't map the port
This also removes the ability to edit existing dockers. This seems like a big issue
Just noticed that non-bridge networks didn't show external ports. Fixed in latest commit
@FunkeCoder23 when you get a chance, could you review the last commit I made to this. I found the NAT detection logic was flawed (based on the old code) and so it wasn't showing external port mappings in many cases. Cheers