jquery-validation-ui icon indicating copy to clipboard operation
jquery-validation-ui copied to clipboard

Fix issue #17: Wire dependencies and handle command objects in remote validation

Open jonroler opened this issue 11 years ago • 4 comments

I also ran into the issue reported in issue #17. My fix is nearly identical to the one proposed by Pascal in the comments for issue #17. The code now wires up spring dependencies into the newly created validatable object before doing the validation which is what would normally be the case for a command object on the server side. Also, it checks to see if the object is a domain object or not before calling isAttached() on it since isAttached() won't be present on command objects. It looks like maybe Pascal never sent you a pull request. Can you please pull this fix in?

jonroler avatar Mar 29 '13 07:03 jonroler

Thanks for sent me the fix. My old laptop just busted and R.I.P. There will be delay for release of the fix till I got my new laptop :(

limcheekin avatar Mar 30 '13 15:03 limcheekin

I had also been working on #17 but I wasn't sure how to submit a pull request. Assuming I cloned this repo, can I just do a commit -a -m"Fixed fooness" ?

Thanks jon

jbowen7 avatar Apr 01 '13 23:04 jbowen7

Can we please look at pulling this fork into master and putting out a new release? I spent quite a bit of time on this, updated the docs with the changes, etc. It's been 9 months since I committed, and it would be very helpful to have this stuff in the official release of this plugin. My project relies on these changes working, and I believe others would benefit as well.

Thanks,

--Jon

jonroler avatar Jan 16 '14 18:01 jonroler

Hi Jon,

Appreciate your contributions and sorry for the slow response. I am on a business trip abroad now till end of the month and will find time to merge your changes and release new version once I back home.

// Chee Kin

limcheekin avatar Jan 16 '14 23:01 limcheekin