templates: Update docker.yaml to use official Docker repository

[crowjdh]

Background

According to the official installation guide for Ubuntu, using get.docker.com script is not recommanded for production environment.

Docker provides a convenience script at get.docker.com to install Docker into development environments quickly and non-interactively. The convenience script is not recommended for production environments, but can be used as an example to create a provisioning script that is tailored to your needs.

So I made changes to examples/docker.yaml according to the official Docker Engine installation guide and replaced convenience-script with apt-get using official Docker repository.

This might not be relevant since lima-vm is still in beta state(assuming it hasn't reached to v1), I thought this might be a good idea for future production-ready lima-vm.

Notes

I purposfully did not update examples/docker-rootful.yaml since rootful environment should be used for test/local development environment only.

[AkihiroSuda]

I purposfully did not update examples/docker-rootful.yaml since rootful environment should be used for test/local development environment only.

Lima itself is made for test/local dev env, so docker.yaml and docker-rootful should have the same design

[crowjdh]

I purposfully did not update examples/docker-rootful.yaml since rootful environment should be used for test/local development environment only.

Lima itself is made for test/local dev env, so docker.yaml and docker-rootful should have the same design

I see. I didn't know lima-vm is not for production environment at it's core.

I made changes anyway to reflect your comments, as well as for docker-rootful.yaml. But since the main goal is not for production environment, I think using get.docker.com is way more simple and fits its purpose. I'll leave this pr up to you to weather merge or reject.

[afbjorklund]

Can we close this ?

[jandubois]

My vote is to close this PR; IMO it adds complexity without providing additional benefits.

[AkihiroSuda]

I'm closing this, but I could be convinced to merge this if this PR were validating the gpg key id, or maybe all the digests of the dpkg files.