jekyll-password-protect icon indicating copy to clipboard operation
jekyll-password-protect copied to clipboard

version bugs for Mac

Open slip-slap opened this issue 3 years ago • 2 comments

slip-slap avatar Feb 23 '22 07:02 slip-slap

There is a small bug with the previous code

slip-slap avatar Feb 23 '22 08:02 slip-slap

Thanks !!! Best wishes

On Tue, Feb 21, 2023 at 4:59 AM Mark Christison @.***> wrote:

@.**** requested changes on this pull request.

In gulpfile.js https://github.com/lilykonings/jekyll-password-protect/pull/13#discussion_r823332932 :

@@ -76,7 +76,7 @@ function encrypt(password) { return callback(); }

  •  var encryptedBody = cryptojs.AES.encrypt(marked(originalBody), password),
    
  •  var encryptedBody = cryptojs.AES.encrypt(marked.parse(originalBody), password),
    

This is the only thing that needs to be in the pull request. You have included many .md files for your specific project, and exposed your password as well

In gulpfile.js https://github.com/lilykonings/jekyll-password-protect/pull/13#discussion_r1112315606 :

@@ -90,7 +90,7 @@ function encrypt(password) {

gulp.task('firewall:encrypt', () => { return gulp.src('_protected/.')

  • .pipe(encrypt('password'))
  • .pipe(encrypt('kismet2357'))

Whoops, exposed your password

— Reply to this email directly, view it on GitHub https://github.com/lilykonings/jekyll-password-protect/pull/13#pullrequestreview-905298643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGG7AMC4FNQ4LBUSTADDQDTWYPLJZANCNFSM5PDRLD7Q . You are receiving this because you authored the thread.Message ID: @.***>

--


〒606-8585 京都市左京区松ケ崎橋上町

         京都工芸繊維大学

         繊維学系

         (Phd, Dr.

         Division of Advanced Fibro-Science

         Kyoto Institute of Technology,

         Matsugasaki, Sakyo-Ku, Kyoto, 606-8585, JAPAN)


          张 辉耀 (ZHANG HUIYAO)

    TEL 080-8716-6955 E-mail:  ***@***.***

slip-slap avatar Feb 22 '23 08:02 slip-slap