whois-parser icon indicating copy to clipboard operation
whois-parser copied to clipboard

add support for IP records

Open azimut opened this issue 6 years ago • 8 comments

I have been trying get the parser work with records returned from an IPs but doesn't seem to work, records from domains work fine.

azimut avatar Feb 09 '20 00:02 azimut

Yes, It doesn't work for me either.

parse whois error: Domain whois data invalid.

monoflash avatar Mar 15 '20 15:03 monoflash

@likexian This seems to be due to validating the WHOIS info using the domain name searchDomain function (obv IP address would have NetName not DomainName)... would you be open to it if I made a PR to validate based on a more consistent value?

EDIT: it occurs to me that it will have fields which don't exist in the parser if we do this... I can make a PR for IP support if this is helpful

EDIT 2: It seems that the intention of the module isn't for general whois info looking at the README. Should IP whois be implemented separate from this project?

thatnerdjosh avatar Apr 27 '20 11:04 thatnerdjosh

Hello @azimut @monoflash @NerdsvilleCEO Sorry for the delay reply.

For now this module only supports domain whois parsing, for ip whois, it is totally different, which can not do the parse directly using the logic of domain.

I will think of it and make a suitable solution to cover the ip whois, but it will not too quickly.

Thanks.

likexian avatar Apr 27 '20 11:04 likexian

@likexian mind if I take this? I will be implementing it anyhow might as well contribute it back

thatnerdjosh avatar Apr 27 '20 11:04 thatnerdjosh

@NerdsvilleCEO Welcome! I will accept PRs only it works well together with domains. :)

It is not an easy job for implementing it, I think it is more economy of energy to leave me to do it. :(

likexian avatar Apr 27 '20 11:04 likexian

hey guys, any update on this?

yabeow avatar Sep 24 '20 03:09 yabeow

Sorry, no.

likexian avatar Sep 24 '20 04:09 likexian

I know this is old but I wanted to add my vote.

edasque avatar Nov 02 '23 20:11 edasque