css-visualizer icon indicating copy to clipboard operation
css-visualizer copied to clipboard

make this into an injectable module

Open thatkookooguy opened this issue 7 years ago • 4 comments

right now, the code isn't prepared to be included in a project.

are you planning to do something like that?

thatkookooguy avatar Aug 07 '16 15:08 thatkookooguy

I would love to inject this into my open-source app

thatkookooguy avatar Aug 07 '16 15:08 thatkookooguy

What sort of API would want the module to have?

likethemammal avatar Aug 11 '16 07:08 likethemammal

A standard one I guess?

maybe just have something like this?

var audio = new Audio('http://audio-source...');
var visualization = new AudioVisualizer(audio);
visualization.setElement('.visualization-container');

maybe even something like:

var visualization = new AudioVisualizer({
  audio: new Audio('http://audio-source...'),
  element: '.visualization-container'
});

It should be clear what a user should do to add this thing to his\her project (ofc, that's only if you want this module to be easily included in other projects)

thatkookooguy avatar Aug 11 '16 11:08 thatkookooguy

Sorry, thought I already replied to this.

I don't plan on adding any additions to this project for a few months. This will be one of the first additions I'll be adding tho. I'll put more thought into what the API would include and put something together that would have some longevity to it.

likethemammal avatar Mar 07 '17 19:03 likethemammal