Bo Chen

Results 92 comments of Bo Chen

@zhenkun @moralismercatus We can start with support of symbolic files with different fixed sizes. A compile-tested-only patch can be found 4f9321551c49981f9f5d9b432ebaf210bb0a72ef. Please help me verify how it works and we...

Yes, I think your interpretation is right. One more comment. The total number of trace as 4 indicates only 4 test cases out of 13 are unique. I am not...

@moralismercatus @zhenkun ~~Please find the fix for checking on duplicated test case with the recent change [here](https://github.com/likebreath/crete-dev/commit/8f12b7edaca55bcfd423164b67a71529013ab62a).~~ Please note that this branch is from [my fork](https://github.com/likebreath/crete-dev/commits/multiple-fix-sized-file), so you need to...

@moralismercatus Thanks for confirming this promptly. We can find a time to talk in details about the questions you and Zhenkun had during the meeting earlier today. Also, if you...

@moralismercatus Good catch. That also needs to be adjusted with "useful_size". I have fixed it in on my branch [here](https://github.com/likebreath/crete-dev/commit/03c64c188f99f953d772ed4ff0bca61c570c607b). Please note that I also adjusted "TestCaseElement::operator==()" to make the...

@moralismercatus The code looks good to me. A minor comment, it will be easier to review the code if you can split changes into smaller change sets, so that each...

I agree the behavior is not normal. Few things I will do to understand what happened: 1. Find the test cases that should not be generated, and check the trace...

It looks good to me. As this merge will be simple, I decide to merge it later (after recent changes from my branch are merged).

@moralismercatus I have reviewed the related code, and found nothing special. "_text_xml" and "_binary" are identical except they are using different boost serialization formt (text_xml and binary). I also checked...

@moralismercatus Thanks for the quick replay. You are right. Binary archive from boost serialization is not portable for cross-platform while other formats of archives are [(ref)](http://www.boost.org/doc/libs/1_63_0/libs/serialization/doc/archives.html#archive_models). No hurry about the...