LiipTestFixturesBundle icon indicating copy to clipboard operation
LiipTestFixturesBundle copied to clipboard

Is doctrine/doctrine-fixtures-bundle required when using theofidry/alice-data-fixtures?

Open tifabien opened this issue 6 years ago • 1 comments

Hi all,

I just installed and tried the new v2.0-alpha8 and got a question related to the doctrine/doctrine-fixtures-bundle dependency requirement. Indeed when I'm using the theofidry/alice-data-fixtures it seems that it needs also the doctrine/doctrine-fixtures-bundle package which seems not really necessary as I think both bundles are doing the same thing.

From what I understand I can see that the requirement check is done when the loadAliceFixture calls the cleanDatabase method. So my question is : Do we really need both bundles? Thanks !

tifabien avatar Oct 30 '18 08:10 tifabien

Here is the relevant code:

https://github.com/liip/LiipTestFixturesBundle/blob/da7a4514ac69b4019925ab9ce2e9a77631d27584/src/Services/FixturesLoaderFactory.php#L40-L42

It was added in https://github.com/liip/LiipFunctionalTestBundle/pull/432

Right now doctrine/doctrine-fixtures-bundle is mentioned in the suggest config of composer.json but not mentioned in the documentation. So maybe it should be added as a dependency, it was a suggestion before the fixtures loading was splited from https://github.com/liip/LiipFunctionalTestBundle.

alexislefebvre avatar Jul 20 '21 21:07 alexislefebvre