LiipMonitorBundle icon indicating copy to clipboard operation
LiipMonitorBundle copied to clipboard

null default values are invalid for many settings expecting integers, e.g. ttl

Open tacman opened this issue 1 year ago • 2 comments

Absent a recipe with default values, at a minimum the bundle should be able to create a valid config file, even if everything is disabled by default.

After installation for version 3 and changing the class name in bundles.php, run

bin/console config:dump-reference liip_monitor > config/packages/monitor.yaml 
bin/console cache:clear

It seems like the configuration should contain reasonable values for ttl, warning_duration, etc.

tacman avatar Mar 23 '24 15:03 tacman

Hmm, the null value means "don't use this feature"

bin/console config:dump-reference liip_monitor > config/packages/monitor.yaml

I don't think you should configure bundles this way. Just add the config you require. That being said, I'll look into why using null causes an error - can you show the exception you see?

kbond avatar Apr 01 '24 13:04 kbond

This is less pressing now that there's a recipe, but still I don't think that command should generate an invalid configuration.

In IntegerNode.php line 26:

Invalid type for path "liip_monitor.checks.groups.name.messenger_transports.name.critical_threshold". Expected "int", but got "null".

tacman avatar Jul 23 '24 13:07 tacman

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 02:04 stale[bot]

This issue has been automatically closed. Feel free to re-open if it is still relevant.

stale[bot] avatar May 06 '25 04:05 stale[bot]