LiipImagineBundle icon indicating copy to clipboard operation
LiipImagineBundle copied to clipboard

Drop support for AWS Version 1 cache resolver in v3?

Open tacman opened this issue 3 years ago • 3 comments

Installing (composer install) shows this warning:

   Package amazonwebservices/aws-sdk-for-php is abandoned, you should avoid using it. Use aws/aws-sdk-php instead.

tacman avatar Feb 09 '22 16:02 tacman

That warning exists only because of support for AWS Version 1 cache resolver. So this is more complicated than it looked at first glance. I'll keep poking at it.

tacman avatar Feb 09 '22 16:02 tacman

i am not super familiar with AWS. can people use AWS with a newer version in this bundle and keep using version 1 for other things, or is that somehow a switch they have to flip? if users can mix api versions i see no problem in us dropping version 1 support in version 3.

dbu avatar Feb 10 '22 08:02 dbu

there is additionally a phpstan warning that we have too many arguments. i ignore that for now but i think we should use 3.x to drop legacy things.

dbu avatar Jan 02 '24 15:01 dbu