liip
Refactor exception handling of `Binary\Loader\ChainLoader` class
| Q | A |
|---|---|
| Branch? | 3.x |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| References | https://github.com/liip/LiipImagineBundle/pull/1432#discussion_r751265173 / https://github.com/liip/LiipImagineBundle/pull/1432#discussion_r753720665 |
| License | MIT |
| Doc | n/a |
This is a work in progress toward refactoring the error handling logic of Liip\ImagineBundle\Binary\Loader\ChainLoader as was originally discussed in code review comments from #1432; see the discussion beginning with dbu's #1432 comment and, more specifically, my (robfrawley) #1432 comment in response.
Additional information will be added as my schedule permits and during this PR's progression.
For the time being, I would greatly appreciate any thoughts from @dbu, @franmomu, or any other maintainer/contributor/user as to the current state of this pull request as well as any alternate possible directions to investigate.
i like this refactoring, thanks!
i agree with the comment from @franmomu about naming the loader variable $loader and making things final where possible.
I've gone ahead and squashed the five commits created while working toward this PR, as well as rebased my changes over the latest 3.x branch. I think this should be just about ready, pending the outcome of https://github.com/liip/LiipImagineBundle/pull/1434#discussion_r757095083 and any additional thoughts that anyone may have after performing any final reviews. As such, I've removed the [WIP] label from the PR title and I request a final quick check from any interested maintainers and contributors.
(At this point, I'll squash and rebase every time any additional changes are required so the PR is always in a clean and easily mergeable state; hopefully such doesn't happen too many times, though :-))