LiipImagineBundle icon indicating copy to clipboard operation
LiipImagineBundle copied to clipboard

Published 20 hours ago • verified publisher icon liip

[WIP][Cache Resolver] Implement relative web path resolver

Open franmomu opened this issue 5 years ago • 2 comments

Q A
Branch? 2.0
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This is https://github.com/liip/LiipImagineBundle/pull/1059 merged with the current master, I fixed the tests and conflicts, ~~but I haven't checked the implementation yet~~.

EDIT:

  • The constructor of WebPathResolver shouldn't be change in case someone has extended this class.
  • I would just instantiate the PathResolver inside the class and I'm not sure if the PathResolverInterface is needed.

franmomu avatar Oct 05 '19 15:10 franmomu

Hey @nmuntyanov @franmomu @michellesanver Can anybody tell me what's the status of this PR? Is anyone still working on it? What's preventing it from being merged? This would be an interesting feature to have.

icedevelopment avatar Aug 21 '20 12:08 icedevelopment

Hi, I don't think someone is working on it, feel free to take over. Based on the comments I wrote:

The constructor of WebPathResolver shouldn't be change in case someone has extended this class.

This should be done in a BC-break way.

I would just instantiate the PathResolver inside the class and I'm not sure if the PathResolverInterface is needed.

Check if it's really needed the interface.

franmomu avatar Aug 30 '20 09:08 franmomu