LiipImagineBundle icon indicating copy to clipboard operation
LiipImagineBundle copied to clipboard

[RFC] removed webpath set to null on unset resolver

Open c33s opened this issue 6 years ago • 3 comments

Q A
Branch? 2.0 would maybe also make sense to backport it
Bug fix? yes (for me yes)
New feature? no
BC breaks? yes (kind of, if someone buld upon this fallback)
Deprecations? no
Tests pass? ?
Fixed tickets #1132
License MIT
Doc PR

alredy commented in https://github.com/liip/LiipImagineBundle/issues/1132#issuecomment-524867253 but i thought a PR is more visible to get comments.

haven't tried to run or fix tests because first it makes sense to know if you would merge this.

c33s avatar Aug 26 '19 14:08 c33s

Thanks for this PR! I would definitely merge this bugfix and release in 3.0 as it is indeed a slight BC break. I'd be super happy if you go ahead and fix the related tests.

michellesanver avatar Oct 04 '19 11:10 michellesanver

sounds great. will have a look at the tests this week

c33s avatar Oct 06 '19 18:10 c33s

i don't think we can simply remove the default resolver. maybe we could add it in the extension class instead of the configuration class to avoid the problem when merging configurations?

dbu avatar Oct 12 '21 07:10 dbu