godot-xterm icon indicating copy to clipboard operation
godot-xterm copied to clipboard

Godot 4

Open ShalokShalom opened this issue 2 years ago • 3 comments

Is this somehow supposed to become ported to Godot 4?

😃

ShalokShalom avatar Oct 27 '22 21:10 ShalokShalom

I am not currently using Godot 4 and don't have time to port it, so no plans for the near future. However, if I start using Godot 4 and have the time, I would certainly like to port it. Forks and contributions to do this are also welcome :slightly_smiling_face:

lihop avatar Oct 27 '22 23:10 lihop

I started a branch https://github.com/Dan2552/godot-xterm/pull/1 (admittedly, mostly just changes made by Godot itself)

There's lots to do on it still (it's certainly nowhere near working) and there's a lot of TODOs, but just incase somebody else picks up, hopefully it saves them a bit of time even if I don't manage to make any more progress.

Notably the GDNative stuff needs changing:

[from https://godotengine.org/article/introducing-gd-extensions]

This is a breaking change to the system. GDNative plugins written for Godot 3 will not run on Godot 4 and vice versa. Plugins written for Godot 3 will need to be altered and compiled for Godot 4.

Dan2552 avatar Nov 09 '22 22:11 Dan2552

I have a bit of time over the new years break, so have started working on the port to Godot 4.

Using https://github.com/Dan2552/godot-xterm/pull/1 as a base, I have created the godot4 branch along with draft PR https://github.com/lihop/godot-xterm/pull/60.

The GDExtension currently compiles on Linux X86_64 and displays some output, but there are still a lot of things broken, so the work continues.

Thanks @Dan2552 for the work you've done so far, it's a wonderful starting point. And thank you @ShalokShalom for motivating the port to Godot 4!

lihop avatar Dec 29 '22 10:12 lihop