workbench icon indicating copy to clipboard operation
workbench copied to clipboard

WorkbenchSplicePlugin causes refreshes

Open jc776 opened this issue 7 years ago • 0 comments

The line override def requires = WorkbenchPlugin causes the 'refresh' plugin to load. It should be override def requires = WorkbenchBasePlugin.

scalaVersion in ThisBuild := "2.12.4"

val client = project.in(file("client"))
  .settings(
    name := "test-client"
  )
  .enablePlugins(ScalaJSPlugin, WorkbenchSplicePlugin)
workbench.js:121:160
Workbench connected
workbench.js:438:172
workbench: Splicing http://localhost:12345\client\target\scala-2.12\test-client-fastopt.js
workbench.js:124:117
workbench: Checking test-client-jsdeps.js.js
workbench.js:124:117
workbench: Checking test-client-jsdeps.js
workbench.js:124:117
workbench: Checking test-client-fastopt.js.js
workbench.js:124:117
workbench: Checking test-client-fastopt.js
workbench.js:124:117
workbench: Reloading Pages...

If I override that, it does load modified files without refreshing, but none of the 'modify methods while preserving state' behaviour works - I don't think any of the munge regexes work on the current fastOptJS.

jc776 avatar Nov 12 '17 08:11 jc776