autowire icon indicating copy to clipboard operation
autowire copied to clipboard

ClientCallable.call() signature

Open zlangbert opened this issue 10 years ago • 6 comments

This is a bit of a nitpick but when call() is expanded it includes a call to Future.map which requires an execution context. My IDE kept deleting the import because it didn't know it needed it. Would it be possible to change the signature of call() to something like call(implicit executor: ExecutionContext)?

zlangbert avatar Feb 03 '15 04:02 zlangbert

Sure

lihaoyi avatar Feb 03 '15 17:02 lihaoyi

Probably call()(implicit executor: ExecutionContext) to be source-compatible, unless you want to remove the parens at the end of the call, which is probably unimportant

lihaoyi avatar Feb 03 '15 17:02 lihaoyi

No you're right, that makes more sense. Thanks!

zlangbert avatar Feb 03 '15 17:02 zlangbert

On this note, is there a way to pass the ExecutionContext explicitly to call?

caente avatar Mar 23 '15 02:03 caente

Not unless we change the signature =P Which nobody has done yet...

lihaoyi avatar Mar 23 '15 02:03 lihaoyi

#57 closes this

Daxten avatar Feb 02 '17 19:02 Daxten