Undo in record from review can undo saved moves

[gthazmatt]

If you review a game and switch to record mode, you can mess up the saved game stack and have to quit and reload the review to get back. I think a possible way to fix this would be to have a way to reload a review if started from an sgf.

[ligi]

what do you mean by "mess up the saved game stack"

[gthazmatt]

This might have made more sense had I just gone to bed and written it up now. Let me try it as a user story.

As a user, when reviewing a game, I may want to switch to record mode in order to try out a variation. Once I am done with that variation, I want to return to the review at the point where I left.

Currently, there are two ways to return to that point. You either switch to review, back up before the variation, and go forward until you hit it again and select the original path, or you undo your new moves in record mode. If, however, you undo one move too many, you end up with a move in the original path that has no record of a next move, so you can't navigate beyond that point. The only way to fix it is to reload the file.

[ligi]

OK now I understand the problem, but I am not a big fan of the Idea for the solution. What if a user wants to edit some SGF then he would have no chance. I think it would be better to mark moves when loading and always keep them

[gthazmatt]

I'm not sure I completely follow you. Let me walk through how I envision the use cases.

1. A user opens an SGF in review mode. At some point, he switches to record mode. He plays out a variation and saves the file. It can be a new file or the same file as the original game is still intact.
2. Same as above, but for whatever reason, instead of playing out a variation, the user wants to overwrite the game starting at the move where he switched to record mode. He presses undo to delete the previous move (as well as all those that follow it) and is presented with a dialog, warning him that this action will delete the saved moves. Even if the user confirms the undo, the original game is still preserved in the SGF file unless specifically overwritten.
3. Same as 1 above, but instead of saving the variation, the user decides to return to review mode. Before returning, a dialog asks the user if he wants to save the moves as a variation or to discard the changes. If discard, the review resumes from the point where it was left.

[ligi]

let's be careful here and do not mess up the UI I have a problem with #3 - that's a little bit contra the mode idea Having a lot of stuff on the agenda anyway - I try to clear some of them first - perhaps there is inspiration on the way ;-)