ligi

Results 616 comments of ligi

this is a bit more complicated - the pictures must look good against a dark background - otherwise goot suggestion

would look really bad with the current images as they have white backgrounds.I have some images with transparency - wanted to do this anyway - just time constraints ;-)

ref: https://github.com/ligi/PassAndroid/issues/107

Thanks for the suggestion - this is planned

Found another one: ``` com.squareup.moshi.JsonDataException: Not an RFC 3339 date: 2023-04-10T17:59:18.150459 at com.squareup.moshi.adapters.Iso8601Utils.parse(Iso8601Utils.java:198) at com.squareup.moshi.adapters.Rfc3339DateJsonAdapter.fromJson(Rfc3339DateJsonAdapter.java:42) at com.squareup.moshi.adapters.Rfc3339DateJsonAdapter.fromJson(Rfc3339DateJsonAdapter.java:35) at com.squareup.moshi.kotlin.reflect.KotlinJsonAdapter.fromJson(KotlinJsonAdapter.kt:86) at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41) at com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory$PolymorphicJsonAdapter.fromJson(PolymorphicJsonAdapterFactory.java:264) at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41) at com.squareup.moshi.kotlin.reflect.KotlinJsonAdapter.fromJson(KotlinJsonAdapter.kt:86) at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41) at...

you are correct - will change

yea - it was google+ and google plus is no more - need to remove it - thanks!

Really great to hear! Especially the TypeScript part - cc @pedrouid

@pedrouid perhaps this was also the problem you had with the kotlin version? These messages have to be handled differently and remembering the problems you described this could explain it....

No - removing the notification body makes it to a data notification. Please see: https://firebase.google.com/docs/cloud-messaging/concept-options