FAST icon indicating copy to clipboard operation
FAST copied to clipboard

doesn't refresh newly installed apps.

Open nihal697 opened this issue 6 years ago • 42 comments

Fast doesn't recognize newly installed apps. so to do that I have to clear cache in settings of the app but that also resets sorting of apps and the apps I pinned to the top. Please look into this issue.

nihal697 avatar Feb 22 '19 20:02 nihal697

This is a known issue. FAST has quite some problems with automatic refreshing of apps that i once attempted to fix in my own fork but i couldn't yet make it compatible with android oreo and the changes also haven't been merged.

In the meantime as a workaround you can use the fact that FAST refreshes on a new start and ends the main activity when entering the settings. So going to settings and back right away will trigger a refresh without the need to clear any data.

Or, if you are familiar with compiling android apps and don't run Android Oreo or newer you could go ahead and compile for yourself with my changes.

SebiderSushi avatar Feb 22 '19 20:02 SebiderSushi

Oh, didn't know that. Thanks for replying so fast. I have one suggestion also, should I say it here or in the pull request section?

nihal697 avatar Feb 22 '19 20:02 nihal697

If your suggestion concerns something to be implemented into the pull request then i think you should post it there. I'm glad to help ^^

SebiderSushi avatar Feb 22 '19 20:02 SebiderSushi

Actually I am new here and I don't understand what exactly pull request means. So let me tell ny suggestion here and if it is inappropriate then I will delete it and add it to pull request. Suggestion is to add a feature which opens apps automatically when the string of letters matches only a single app. I saw it on an open source app the link of whose sources I am providing here : https://github.com/vackosar/search-based-launcher/ Tell me if I should delete it from here, please. Hope you like the idea.

nihal697 avatar Feb 22 '19 20:02 nihal697

I am literally sorry that I didn't notice it is already in the settings. Extremely sorry sir. (._.)

nihal697 avatar Feb 22 '19 20:02 nihal697

No Problem, settings of new apps can be quite confusing sometimes. :D

SebiderSushi avatar Feb 22 '19 20:02 SebiderSushi

Certainly it is. Thank you again. ❤️ Will close the issue as you said it is already known.

nihal697 avatar Feb 22 '19 20:02 nihal697

I think you should leave it open until it is fixed for good.

SebiderSushi avatar Feb 22 '19 20:02 SebiderSushi

done.

nihal697 avatar Feb 22 '19 20:02 nihal697

I've just completed my rework of FASTs app list update mechanisms. The only thing necessary now is to test it and polish it up before release. If you would want to test this it would greatly be appreciated as I can't properly test it under real life conditions since I don't use Android 8.0 or newer on my main device. If you are familiar with building android apps go ahead and compile my feature branch. If not, I have uploaded a testing build on my forked repository that can be installed alongside the official FAST application.

SebiderSushi avatar May 12 '19 04:05 SebiderSushi

Hey, I would really love to help you in testing the app out, although unfortunately I don't know how to build apps, so I will go for the testing build. :D

On Sun, 12 May 2019, 10:05 Sebastian, [email protected] wrote:

I've just completed my rework of FASTs app list update mechanisms. The only thing necessary now is to test it and polish it up before release. If you would want to test this it would greatly be appreciated as I can't properly test it under real life conditions since I don't use Android 8.0 or newer on my main device. If you are familiar with building android apps go ahead and compile my feature branch. If not, I have uploaded a testing build https://github.com/SebiderSushi/FAST/releases/tag/redesign_receiever on my forked repository that can be installed alongside the official FAST application.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-491563887, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTI77DJ77URFLAM7KBLPU6NBLANCNFSM4GZJJHMA .

nihal697 avatar May 12 '19 06:05 nihal697

Fast-debug_redesign_test_v00.apk The test build is with this name right, just to confirm?

On Sun, 12 May 2019, 11:33 Na Cl2, [email protected] wrote:

Hey, I would really love to help you in testing the app out, although unfortunately I don't know how to build apps, so I will go for the testing build. :D

On Sun, 12 May 2019, 10:05 Sebastian, [email protected] wrote:

I've just completed my rework of FASTs app list update mechanisms. The only thing necessary now is to test it and polish it up before release. If you would want to test this it would greatly be appreciated as I can't properly test it under real life conditions since I don't use Android 8.0 or newer on my main device. If you are familiar with building android apps go ahead and compile my feature branch. If not, I have uploaded a testing build https://github.com/SebiderSushi/FAST/releases/tag/redesign_receiever on my forked repository that can be installed alongside the official FAST application.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-491563887, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTI77DJ77URFLAM7KBLPU6NBLANCNFSM4GZJJHMA .

nihal697 avatar May 12 '19 06:05 nihal697

Yes :)

SebiderSushi avatar May 12 '19 06:05 SebiderSushi

It isn't being installed, i am running on a custom rom based on 8.1

On Sun, 12 May 2019, 11:37 Sebastian, [email protected] wrote:

Yes :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-491567531, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTITMJTCP6ZFE7U5S2TPU6X3TANCNFSM4GZJJHMA .

nihal697 avatar May 12 '19 06:05 nihal697

It finally got installed when i did that from mixplorer's inbuilt installer, strangely android package installer was unable to do this. I disabled one app just now and it got updated quickly, will report further if any issues found. Thanks

On Sun, 12 May 2019, 11:38 Na Cl2, [email protected] wrote:

It isn't being installed, i am running on a custom rom based on 8.1

On Sun, 12 May 2019, 11:37 Sebastian, [email protected] wrote:

Yes :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-491567531, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTITMJTCP6ZFE7U5S2TPU6X3TANCNFSM4GZJJHMA .

nihal697 avatar May 12 '19 06:05 nihal697

Very strange. But good that it worked anyway. Thank you very much for putting your trust and time into this and testing!

SebiderSushi avatar May 12 '19 06:05 SebiderSushi

That's just your generosity sir, oh and I don't trust you at all btw :p I tried disabling and uninstalling apps and then quickly checking them in the FAST, it was working fine each and every time so i guess this mechanism is absolutely working well. :D

On Sun, 12 May 2019, 11:44 Sebastian, [email protected] wrote:

Very strange. But good that it worked anyway. Thank you very much for putting your trust and time into this and testing!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-491567893, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTLHE6D5SKSMFT6KO3DPU6YUZANCNFSM4GZJJHMA .

nihal697 avatar May 12 '19 16:05 nihal697

But installing an app someone else built sure needs to happen out of at least a little bit of trust.

SebiderSushi avatar May 12 '19 17:05 SebiderSushi

Okay then, I love you too.

On Sun, 12 May 2019, 22:51 Sebastian, [email protected] wrote:

But installing an app someone else built sure needs to happen out of at least a little bit of trust.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-491613290, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTI3VYJAHCCKQOWA4SDPVBGYJANCNFSM4GZJJHMA .

nihal697 avatar May 12 '19 17:05 nihal697

Hello, It's been quite a time and I didn't find any issue in FAST except that most of the times if an app is uninstalled from another launcher or from settings directly, FAST doesn't recognise the uninstallation. Thanks. :D

nihal697 avatar Jun 03 '19 19:06 nihal697

Okay this should not happen. Could you give the details specified in the last paragraph of the release notes of the testing build to give a clearer image? Also if you might know anything that could be important when reproducing this bug that would be helpful too.

SebiderSushi avatar Jun 07 '19 17:06 SebiderSushi

Yep sure

  1. 116 apps
  2. Icon resolution is 48
  3. I can't really tell about the workload as I didn't even notice it. :(
  4. Fast isn't set as default. To reproduce the issue you can set some other launcher as default and uninstall any app either from that launcher or from android settings. FAST won't notice the uninstallation most probably. Even force stopping FAST doesn't work. It isn't the case if it is set as default launcher.

-------- Original Message -------- From: Sebastian [email protected] Sent: June 7, 2019 5:04:54 PM UTC To: ligi/FAST [email protected] Cc: Nihal Anand [email protected], State change [email protected] Subject: Re: [ligi/FAST] doesn't refresh newly installed apps. (#113)

Okay this should not happen. Could you give the details specified in the last paragraph of the release notes of the testing build to give a clearer image? Also if you might know anything that could be important when reproducing this bug that would be helpful too.

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/ligi/FAST/issues/113#issuecomment-499963328

nihal697 avatar Jun 08 '19 06:06 nihal697

Thank You very much for the information. I will look into it when i find the time.

SebiderSushi avatar Jun 10 '19 07:06 SebiderSushi

You're welcome and thank you too.

On June 10, 2019 7:34:43 AM UTC, Sebastian [email protected] wrote:

Thank You very much for the information. I will look into it when i find the time.

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/ligi/FAST/issues/113#issuecomment-500321590

-- Sent from my Android device with Librem Mail. Please excuse my brevity.

nihal697 avatar Jun 10 '19 11:06 nihal697

Okay i have been using the testing build for about a week now since i finally have a daily driver phone running Oreo (more precisely LineageOS 15.1). Having set Trebuchet as the default launcher i could not reproduce your observations, being FAST not recognizing an app being uninstalled from Trebuchet. May i ask which ROM you are using?

The only issue i found to be reproducible on my system seems to be that on Oreo FAST doesn't recognize it automatically if a "component" is enabled or disabled. For example there are Apps that offer to manually specify in their settings to hide or show one of their activities. I also found the error in the code that probably causes this and will fix it right now.

SebiderSushi avatar Jun 30 '19 11:06 SebiderSushi

Correction: While investigating the issue of FAST not detecting components correctly i managed to reproduce your error: The issue i was investigating turned out to consist of two parts, one of them being the error in the code i already found and the other one being the issue you were observing.

The fixed version can now be downloaded from my release page (just pick the latest one).

Explanation

 It happended to be that if the list of changed packages was too short, then the refresh mechanism that should refresh only said changed packages on a fresh FAST launch (i.e. FAST has been terminated some time before) would be very quick. Due to a mistake i made this would lead to a situation where (i guess) somehow the mechanism would save the refreshed app list to disk while the user interface would have already loaded the previous version from disk and therefore keeps displaying that and then saves that outdated list later when you leave FAST, overwriting the refreshed list.  I probably always (un)installed multiple apps while trying to reproduce your issue. In these cases the refreshing mechanism would take long enough for the user interface to completely initalize. At that point instead of writing the new list to disk, it will be sent directly to the running user interface and so the changes are applied.  My fix simply consists in making sure that the callback resposible for sending the updated list directly to the user interface gets initialized before the updating mechanism is executed.

SebiderSushi avatar Jun 30 '19 16:06 SebiderSushi

That's really great to hear, although I didn't understand the technicalities much. Thanks a lot sir, once again! :D

On June 30, 2019 4:19:41 PM UTC, Sebastian [email protected] wrote:

Correction: While investigating the issue of FAST not detecting components correctly i managed to reproduce your error: The issue i was investigating turned out to consist of two parts, one of them being the error in the code i already found and the other one being the issue you were observing.

The fixed version can now be downloaded from my release page.

Explanation

 It happended to be that if the list of changed packages was too short, then the refresh mechanism that should refresh only said changed packages on a fresh FAST launch (i.e. FAST has been terminated some time before) would be very quick. Due to a mistake i made this would lead to a situation where (i guess) somehow the mechanism would save the refreshed app list to disk while the user interface would have already loaded the previous version from disk and therefore keeps displaying that and then saves that outdated list later when you leave FAST, overwriting the refreshed list.  I probably always (un)installed multiple apps while trying to reproduce your issue. In these cases the refreshing mechanism would take long enough for the user interface to completely initalize. At that point instead of writing the new list to disk, it will be sent directly to the running user interface and so the changes are applied.  My fix simply consists in making sure that the callback resposible for sending the updated list directly to the user interface gets initialized before the updating mechanism is executed.

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/ligi/FAST/issues/113#issuecomment-507048924

nihal697 avatar Jul 02 '19 05:07 nihal697

Hello I know it's been a long time, so how are you? i was just confused about if you ever pushed the test builds of Fast app to fdroid/playstore? thanks.

On Tue, Jul 2, 2019, 10:49 AM Nihal @.***> wrote:

That's really great to hear, although I didn't understand the technicalities much. Thanks a lot sir, once again! :D

On June 30, 2019 4:19:41 PM UTC, Sebastian @.***> wrote:

Correction: While investigating the issue of FAST not detecting components correctly i managed to reproduce your error: The issue i was investigating turned out to consist of two parts, one of them being the error in the code i already found and the other one being the issue you were observing.

The fixed version can now be downloaded from my release page https://github.com/SebiderSushi/FAST/releases. Explanation

It happended to be that if the list of changed packages was too short, then the refresh mechanism that should refresh only said changed packages on a fresh FAST launch (i.e. FAST has been terminated some time before) would be very quick. Due to a mistake i made this would lead to a situation where (i guess) somehow the mechanism would save the refreshed app list to disk while the user interface would have already loaded the previous version from disk and therefore keeps displaying that and then saves that outdated list later when you leave FAST, overwriting the refreshed list. I probably always (un)installed multiple apps while trying to reproduce your issue. In these cases the refreshing mechanism would take long enough for the user interface to completely initalize. At that point instead of writing the new list to disk, it will be sent directly to the running user interface and so the changes are applied. My fix simply consists in making sure that the callback resposible for sending the updated list directly to the user interface gets initialized before the updating mechanism is executed.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113?email_source=notifications&email_token=ALJAPTPCJDA325WKPQLWAGTP5DMJ3A5CNFSM4GZJJHMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4PHXA#issuecomment-507048924, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJAPTJ4REUBY5C67ETJ26LP5DMJ3ANCNFSM4GZJJHMA .

nihal697 avatar Aug 17 '22 18:08 nihal697

I pushed a new build on my release page. It's still not up to code but should work. I put together the existing code and fixed some bits here and there.

At some point i stopped using FAST and stopped working on the patch. It was left lingering for about 3 years now and is 5 years old in total. I wouldn't get my hopes up that it will ever get merged at this stage. Right now it is what it is but it should work pretty ok.

SebiderSushi avatar Aug 21 '22 10:08 SebiderSushi

yeah, that's totally understandable. Much thanks and appreciation for pushing another build for just a guy :) I dont understand the difference between extras and no extras version. Can you tell me? Also, which launcher do you use nowadays ? Thanks again

On Sun, Aug 21, 2022, 4:17 PM Sebastian @.***> wrote:

I pushed a new build on my release page. https://github.com/SebiderSushi/FAST/releases It's still not up to code but should work. I put together the existing code and fixed some bits here and there.

At some point i stopped using FAST and stopped working on the patch. It was left lingering for about 3 years now and is 5 years old in total. I wouldn't get my hopes up that it will ever get merged at this stage. Right now it is what it is but it should work pretty ok.

— Reply to this email directly, view it on GitHub https://github.com/ligi/FAST/issues/113#issuecomment-1221520838, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJAPTPKMHDD56VH3I7GYIDV2ICNVANCNFSM4GZJJHMA . You are receiving this because you modified the open/close state.Message ID: @.***>

nihal697 avatar Aug 21 '22 11:08 nihal697