lightstep-tracer-javascript icon indicating copy to clipboard operation
lightstep-tracer-javascript copied to clipboard

GRPC transport

Open ruiaraujo opened this issue 6 years ago • 7 comments

The javascript version only provides thrift as a transport option. Is there anything that would prevent using the GRPC version available in other languages?

ruiaraujo avatar Sep 02 '18 09:09 ruiaraujo

Thanks for opening this issue! We recently added support for proto over http transport; Is this sufficient?

austinlparker avatar Sep 24 '18 18:09 austinlparker

I think so, it would be nice to have a performance comparison between the transport types. 😉

Also I do not see a release, feel free to close this when the release is done.

ruiaraujo avatar Sep 25 '18 06:09 ruiaraujo

Hi @ruiaraujo! I'm going to be investigating adding gRPC support.

Two questions:

  1. Are you using the tracer for node, the browser, or both? I anticipate that node may be ready first.
  2. Have you had a chance to try proto over http?

iredelmeier avatar Nov 09 '18 22:11 iredelmeier

Node.

Not yet because somehow our collector has issues with this and I would like to either see a benchmark or benchmark it myself before changing anything.

ruiaraujo avatar Nov 30 '18 18:11 ruiaraujo

@iredelmeier any chance to work on this? Our node apps are out in the rain compared to the Golang based friends. 😄

ruiaraujo avatar Apr 25 '19 21:04 ruiaraujo

Resurrecting this issue! I think with https://github.com/lightstep/lightstep-benchmarks available now we may be able to run a benchmark between proto and thrift transports. The other thing to consider is the library size, with proto transport included it definitely significantly increases the size. Since you're using the tracer on Node & not browser that may not be relevant.

sbaum1994 avatar Dec 10 '19 01:12 sbaum1994

@sbaum1994 it would be very helpful to have support for the JS version in the benchmark, it would encourage me to showcase some patches we can do the reduce the overhead in the tracer implementation.

At this stage, I care more about runtime performance since we are heavily relying on tracing in the server side.

ruiaraujo avatar Dec 10 '19 19:12 ruiaraujo