java-stellar-sdk icon indicating copy to clipboard operation
java-stellar-sdk copied to clipboard

Published 20 hours ago • verified publisher icon lightsail-network

chore: add codecov related configuration.

Open overcat opened this issue 1 year ago • 5 comments

Add codecov related configuration to display test coverage on the GitHub PR page.

overcat avatar Feb 27 '24 01:02 overcat

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

codecov-commenter avatar Feb 27 '24 01:02 codecov-commenter

Hi @sreuland @tamirms, could you add an approving review?

overcat avatar Mar 01 '24 16:03 overcat

Hi @sreuland @tamirms, could you add an approving review?

Hello @overcat, this looks great, i think we want to first check with our ops, and see if there is any preference from them on a preferred gh coverage tool, will respond with findings, thanks!

cc: @mollykarcher

sreuland avatar Mar 01 '24 17:03 sreuland

Hello @overcat, this looks great, i think we want to first check with our ops, and see if there is any preference from them on a preferred gh coverage tool, will respond with findings, thanks!

I spoke to our Ops team, and they recommend not using the GHA coverage tools, instead each repo is encouraged to use a code coverage tool locally in the projects build, so in java's case, can we look into using a gradle based coverage tool that can be locally run as part of build lifecycle locally, like JaCoCo ?

sreuland avatar Mar 05 '24 17:03 sreuland

Hello @overcat, this looks great, i think we want to first check with our ops, and see if there is any preference from them on a preferred gh coverage tool, will respond with findings, thanks!

I spoke to our Ops team, and they recommend not using the GHA coverage tools, instead each repo is encouraged to use a code coverage tool locally in the projects build, so in java's case, can we look into using a gradle based coverage tool that can be locally run as part of build lifecycle locally, like JaCoCo ?

We are using Jacoco, but I currently do not have a mandatory requirement for tests to fail when the coverage decreases, and I have added an extra step to upload the results to the Codecov platform so that we can see online which code has been tested. https://github.com/stellar/java-stellar-sdk/blob/14a4e6e5d21b483b8321b578306d643cb498f9d2/build.gradle.kts#L131-L133

overcat avatar Mar 05 '24 23:03 overcat