acorn icon indicating copy to clipboard operation
acorn copied to clipboard

Dark-mode

Open kbonnici opened this issue 2 years ago • 5 comments
trafficstars

kbonnici avatar Jun 05 '23 21:06 kbonnici

@kbonnici I changed the base branch so we could get an easier compare

Connoropolous avatar Jun 05 '23 21:06 Connoropolous

Just something that I noticed when you first open acorn.

image

image

Here it is possible to see it. (Harder to in the screenshot but still possible if you stare at it 😅.) You can see a slight color difference. image

Also, I have been itching to help a little bit. let me know if I can.

TechSupport26 avatar Jun 09 '23 21:06 TechSupport26

@Connoropolous can you or pegah confirm this? i dont know if it's my monitor but i can't see a different color.

Also @TechSupport26 you are more than welcome to help with this if you'd like! :D If you just follow the pattern that's present in the commits you should (hopefully) be able to figure out how to make each component have a dark. mode. it's basically just adding the theme value from useTheme() and putting it into the components that need it, where they need it, and then applying light/dark mode selectors in the scss files accordingly.

kbonnici avatar Jun 09 '23 22:06 kbonnici

I will give it ago. Just let me know if I make a muck of things. 😁

Also, it is not an issue when the color scheme is white. Just that it is very noticible when dark. It is a cool indicator to show that projects are actully there and are being loaded.

TechSupport26 avatar Jun 09 '23 22:06 TechSupport26

I have made one change but I am not able to push.

TechSupport26 avatar Jun 14 '23 08:06 TechSupport26