multi: generate and pass along HTLC resolution blobs for aux channels

[Roasbeef]

In this commit, we remove the old blockers on aux channel HTLC resolver logic. In place, we utilize a new set of aux blobs obtained from the AuxContractResolver to generate blobs that contain everything needed to resolve an aux HTLC. This information is now stored on disk in the cnct within the taproot briefcase. Each time we go to have the sweeper handle an HTLC output, we'll now pass along the blob along side, just like we do for the commitment outputs. Finally, we add a new Preimage method to the input.Input interface. As the preimage may only be known after the fact (reveal by peer on/off chain), we need a way to give the AuxSweeer a way to obtain the preimage to complete any final witnesses.

[github-actions[bot]]

Pull reviewers stats

Stats of the last 30 days for lnd:

	User	Total reviews	Time to review	Total comments
	guggero 🥇	8 ▀▀	3h 5m	4
	Roasbeef 🥈	6 ▀	2d 2h 11m ▀	17 ▀▀
	ziggie1984 🥉	6 ▀	1d 7h 24m	22 ▀▀
	bhandras	5 ▀	35m	1
	yyforyongyu	5 ▀	1d 23h 37m ▀	10 ▀
	ellemouton	4 ▀	2d 23h 3m ▀	8 ▀
	ProofOfKeags	3 ▀	23h 7m	18 ▀▀
	bitromortac	3 ▀	12h 4m	0
	dstadulis	2	3d 4h 6m ▀	2
	saubyk	2	7d 19h 17m ▀▀▀	4
	ViktorTigerstrom	1	3d 15h 2m ▀	1
	GeorgeTsagk	1	2h 19m	0
	calvinrzachman	1	2d 2h 39m ▀	6 ▀
	carlaKC	1	1h 27m	0

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

:label: Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Roasbeef]

Not sure what to make of the test failure to FuzzReplyChannelRange. Nothing in this PR touches anything related to that...

[guggero]

Not sure what to make of the test failure to FuzzReplyChannelRange. Nothing in this PR touches anything related to that...

I think we might need https://github.com/lightningnetwork/lnd/pull/9082 to be added to the 0-18-4-branch-rc1. Will try that out today.

EDIT: Yes, needed to add #9082 and #9084 to fix the fuzz tests.

[Roasbeef]

Fixed the lnwallet failing case. Rebased on top of the latest version of 0-18-4-branch-rc1.

[Roasbeef]

Rebasing to target against the master branch, then we'll cherry-pick it into that v0.18.4 staging branch.

[guggero]

Pushed up a commit to update the release notes to trigger a CI run (changing the base apparently didn't do that).