lnd icon indicating copy to clipboard operation
lnd copied to clipboard

release: create branch for v0.18.4-beta.rc1

Open guggero opened this issue 1 year ago • 3 comments

Preparation PR to kick off the v0.18.4-beta.rc1 release.

Closes #9173.

This PR includes rebased versions of the following PRs (in order):

  • #8996
  • #8520
  • #9007
  • #9025
  • #9030
  • #9044
  • #9049
  • #8981
  • #9072
  • #9095
  • #9134
  • #8960
  • #9154
  • #9187
  • #9059

PRs not yet included but required for v0.18.4-beta (even RC1):

  • https://github.com/lightningnetwork/lnd/pull/9194
  • https://github.com/lightningnetwork/lnd/pull/9074 (once merged and re-opened against master)

NOTE: Replaces https://github.com/lightningnetwork/lnd/pull/9174 to have branch in upstream repo.

guggero avatar Oct 14 '24 14:10 guggero

Pull reviewers stats

Stats of the last 30 days for lnd:

User Total reviews Time to review Total comments
guggero
🥇
8
▀▀
3h 5m
4
Roasbeef
🥈
6
2d 2h 11m
17
▀▀
bhandras
🥉
5
35m
1
yyforyongyu
5
1d 9h 39m
12
ziggie1984
5
1d 17h 31m
22
▀▀
ProofOfKeags
3
23h 7m
18
▀▀
ellemouton
3
6d 14h 57m
▀▀
8
bitromortac
3
12h 4m
0
saubyk
2
7d 19h 17m
▀▀▀
4
dstadulis
1
6d 3h 54m
▀▀
0
GeorgeTsagk
1
2h 19m
0
calvinrzachman
1
2d 2h 39m
6
carlaKC
1
1h 27m
0

github-actions[bot] avatar Oct 14 '24 14:10 github-actions[bot]

Added https://github.com/lightningnetwork/lnd/pull/9187.

guggero avatar Oct 15 '24 15:10 guggero

Added https://github.com/lightningnetwork/lnd/pull/9059.

guggero avatar Oct 16 '24 14:10 guggero

Added #9195.

guggero avatar Oct 21 '24 11:10 guggero

Added #9197.

guggero avatar Oct 22 '24 07:10 guggero

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

:label: Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 25 '24 09:10 coderabbitai[bot]

Added #9199.

guggero avatar Oct 25 '24 09:10 guggero

Added #9223.

guggero avatar Oct 30 '24 13:10 guggero

We'll need this PR in this branch as well: https://github.com/lightningnetwork/lnd/pull/9062

Roasbeef avatar Nov 08 '24 02:11 Roasbeef

Added #9062 and updated its milestone to 0.18.4.

guggero avatar Nov 08 '24 07:11 guggero

Added #9084 and #9082.

guggero avatar Nov 13 '24 11:11 guggero

Pushed up a version of this w/ the HTLC PR to my fork (temp): https://github.com/lightningnetwork/lnd/compare/0-18-4-branch-rc1...Roasbeef:lnd:0-18-4-branch-rc1?expand=1

Roasbeef avatar Nov 15 '24 00:11 Roasbeef

Added #9194. Ready for full review now!

guggero avatar Nov 15 '24 12:11 guggero

Added https://github.com/lightningnetwork/lnd/pull/9272

Roasbeef avatar Nov 16 '24 01:11 Roasbeef

Added #9272

Force pushed the fixed version of #9272.

guggero avatar Nov 19 '24 11:11 guggero

We'll also want to pull this one in: https://github.com/lightningnetwork/lnd/pull/9253. \

Roasbeef avatar Nov 20 '24 00:11 Roasbeef

Added #9253.

guggero avatar Nov 20 '24 09:11 guggero

We'll also want https://github.com/lightningnetwork/lnd/pull/9288, but can add that after the RC lands if necessary.

guggero avatar Nov 20 '24 09:11 guggero

Added #9288.

guggero avatar Nov 20 '24 14:11 guggero