funding: add timeout to channel batch funding

[hieblmi]

Fixes https://github.com/lightningnetwork/lnd/issues/8362.

In this PR we add a context deadline for the batch channel funding process. This gracefully ends the funding process if one or more of the batche's peers are unresponsive. Within the deadline window, the user can abort a pending batch opening via Ctrl+C. The blocking peers will be logged. An aborted batch will cancel all channel openings. The user has to restart with an adjusted batch.

[hieblmi]

Ready for review - unit tests still need to be fixed and an itest will be added.

[ziggie1984]

I wonder if we already have a timeout for the single-channel funding flow ?

[Roasbeef]

I wonder if we already have a timeout for the single-channel funding flow ?

Yep we do, IIUC users wanted the batch funding attempts to time out sooner?

[coderabbitai[bot]]

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hieblmi]

Thanks for review and follow-up @ziggie1984, will add the single flow cancellation to my todos.

[ziggie1984]

So the only downside of this approach is, that if one opening fails because for example pending channels are exeeded (by the peer), than we would wait for the timeout (60 sec) to hit, so I think the errorGroupCtx is the more elegant way but requires some itest adoption. I am fine with both.

[hieblmi]

Haven't forgotten about this an want to pick it up soon.

[lightninglabs-deploy]

@roasbeef: review reminder @hieblmi, remember to re-request review from reviewers when ready

[dstadulis]

@saubyk Since https://github.com/lightningnetwork/lnd/pull/8406 was merged and fixed https://github.com/lightningnetwork/lnd/issues/8362, it seems this PR should be closed

[guggero]

I think we should keep the PR. Having a timeout is useful here, independent of the other fixes. Not having one just helped us discover the underlying issue.

[lightninglabs-deploy]

@roasbeef: review reminder @ziggie1984: review reminder @hieblmi, remember to re-request review from reviewers when ready