lnd icon indicating copy to clipboard operation
lnd copied to clipboard

Linter checks go versions in Dockerfile and YAML files

Open ffranr opened this issue 1 year ago • 1 comments

Change Description

This PR adds two checks to the linter. These checks ensure that the Go version used in Dockerfile files and YAML files are consistent and as expected.

Steps to Test

Check to ensure that the CI linter Go version check output is correct.

Pull Request Checklist

Testing

  • [ ] Your PR passes all CI checks.
  • [ ] Tests covering the positive and negative (error paths) are included.
  • [ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

ffranr avatar Nov 20 '23 18:11 ffranr

@ffranr, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar May 20 '24 05:05 lightninglabs-deploy

@ffranr, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Jun 03 '24 07:06 lightninglabs-deploy

Closing due to inactivity

lightninglabs-deploy avatar Jun 05 '24 14:06 lightninglabs-deploy

Closing due to inactivity

lightninglabs-deploy avatar Jun 05 '24 15:06 lightninglabs-deploy

Closing due to inactivity

lightninglabs-deploy avatar Jun 05 '24 16:06 lightninglabs-deploy

Closing due to inactivity

lightninglabs-deploy avatar Jun 05 '24 17:06 lightninglabs-deploy

Closing due to inactivity

lightninglabs-deploy avatar Jun 05 '24 19:06 lightninglabs-deploy

following the orders of the bot 🤓 feel free to re-open!

ellemouton avatar Jun 05 '24 19:06 ellemouton

@guggero Thanks for the review! I've addressed your comments here: https://github.com/lightningnetwork/lnd/pull/8954 I couldn't reopen this PR, I think because I forced push before re-opening, not sure.

ffranr avatar Jul 30 '24 01:07 ffranr