lnd
lnd copied to clipboard
Modified the listchanneltxn subcommand
Change Description
start_height must be <= end_height, error otherwise transactions are returned in direct order (oldest first) an additional flag --reverse is added to change the order (--reverse true, recent first) Modified docs by modifying comments in the listchaintxn description command
Steps to Test
Carry out a debug installation using this command:
make && make install
Test command:
./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000| grep block_height
Expected outcome: transactions are returned in the order, oldest first
./lncli-debug --no-macaroons listchaintxns --start_height 7000 --end_height 200| grep block_height
Expected outcome: Error
./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000 --reverse| grep block_height
Expected outcome: transactions are returned in the reverse order, newest first
Change after review
Test command:
./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000 --reverse| grep block_height
Expected outcome: transactions are returned in the order, oldest first
./lncli-debug --no-macaroons listchaintxns --start_height 7000 --end_height 200| grep block_height
Expected outcome: Error
./lncli-debug --no-macaroons listchaintxns --start_height 200 --end_height 7000| grep block_height
Expected outcome: transactions are returned in the order, newest first
Thanks would this involve amending existing commit messages or would I have to take Git HEAD to the tip before I started making changes then make all the changes one after the other, to get the commit to look like that
Thanks would this involve amending existing commit messages or would I have to take Git HEAD to the tip before I started making changes then make all the changes one after the other, to get the commit to look like that
In this case I would take the second approach. You can reset your head while keeping the changes (git reset --soft HEAD~2
), then add the couple of fixes + create the right commit structure (git commit -p
is your friend here).
When the log is in good shape remember to add one last commit updating the release notes (you can check other PRs to see how it's done)
ok working on it @positiveblue
I have made the change @positiveblue
@Chinwendu20 - are you planning to continue work on this? if so, please click the "re-request" review button :)
Yes, thank you. Just seeing that there is a conflict. I will fix it and re-request a review @ellemouton
@Chinwendu20 - it seems that not all the comments left in the previous review have been addressed?
Thanks please do you know how I can reply to those reviews. Last time I did that it showed pending and @positiveblue could not see it.
you have to go into "Files Changed" and then click the "Review Changes" button. Then you will be able to click "Submitt Review" which would submit your comments
Okay thank you
Hello @positiveblue please I have made changes to this PR do you mind reviewing it again?
Reverting the lnrpc changes... hold on
All done. Ready for review.
Hello, I have added the release note and fixed the lint error, do you mind rerunning the workflow?
So sorry for the back and forth, for some reason. I cannot seem to see any linting error like it is on the CI when I run make lint
locally:
@Chinwendu20 Is there anything I could help with so that we could get this PR? The CI regards Linting the code seems passed.
@Chinwendu20 I had a similar issue regards running the make lint
command since I've 8GB of RAM. This is solved by passing the number of concurrent workers to be 1 so the full command make lint workers=1
hope it works for you :)
So sorry for the back and forth, for some reason. I cannot seem to see any linting error like it is on the CI when I run make lint locally:
Thanks @mohamedawnallah. I think I was waiting for review here?
@positiveblue: review reminder