lnd icon indicating copy to clipboard operation
lnd copied to clipboard

[feature]: listchannels output should include node alias

Open Roasbeef opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe.

Many applications want to display a node's alias along side the set of displayed channels. Today that information isn't returned, so then an application needs to hit GetNodeInfo for each of the channels, which can really slow down loading 1000s of channels for a large node.

Describe the solution you'd like

Add a new alias field to the ListChannels RPC call.

Describe alternatives you've considered

Applications could use GetNodeInfo with --include_channels, but that'll only show the graph level information and not also the link level information. As an alternatively, we could add more link level channel info here (capacity, balance, etc, etc).

Roasbeef avatar Oct 06 '22 00:10 Roasbeef

Additionally it would be great to have alias information on the lncli fwdinghistory events, maybe through new fields alias_in and alias_out. Edit: Created a feature request for this: https://github.com/lightningnetwork/lnd/issues/7000

hieblmi avatar Oct 06 '22 12:10 hieblmi

Hello. I'm new to the development of the Lightning Network Daemon. I would like to work on this issue.

araujo88 avatar Oct 07 '22 02:10 araujo88

Hi, I have taken up this issue since the related PR is closed since a while. The changes required here resemble changes in https://github.com/lightningnetwork/lnd/pull/7001. I have working code for a peer alias in ListChannels and will submit it with tests soon.

hieblmi avatar Jan 13 '23 02:01 hieblmi

Hello @hieblmi . Are you still working on this? Or can I take this on

Chinwendu20 avatar Feb 23 '23 04:02 Chinwendu20

Hi @Chinwendu20, I am still working on it here: https://github.com/lightningnetwork/lnd/pull/7322. Please feel free to review the code if you want to.

hieblmi avatar Feb 23 '23 05:02 hieblmi

@saubyk this ticket can be closed as https://github.com/lightningnetwork/lnd/pull/7322 was merged.

hieblmi avatar Feb 25 '23 10:02 hieblmi

Fixed by #7322.

guggero avatar Feb 25 '23 10:02 guggero