lnd icon indicating copy to clipboard operation
lnd copied to clipboard

Incorrect version precedence in the v0.15.1-beta track

Open burdiyan opened this issue 3 years ago • 1 comments

Background

It seems like the versioning scheme you've chosen for v0.15.1-beta track is not compatible with SemVer.

We noticed that because our Renovate bot setup wanted to upgrade our LND dependency from v0.15.1-beta to v0.15.1-beta.rc2 although the former is released as newer than the latter by LND.

I thought the issue was inside Renovate, but a coworker pointed out to the SemVer spec, and Renovate seems to be doing the correct thing. See point 11 in the spec:

Example: 1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-alpha.beta < 1.0.0-beta < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1 < 1.0.0.

So 1.0.0-alpha is lower than 1.0.0-alpha.1 which seems to fit this example with LND version.

burdiyan avatar Sep 21 '22 11:09 burdiyan

Related issue: https://github.com/lightningnetwork/lnd/issues/6860

Roasbeef avatar Sep 21 '22 18:09 Roasbeef