lnd icon indicating copy to clipboard operation
lnd copied to clipboard

Add tests for warning messages from peers

Open positiveblue opened this issue 3 years ago • 1 comments

Change Description

Test that warning messages from our peers do not trigger any action.

Steps to Test

pushd htlcswitch && go test -v -run TestChannelLinkFail && popd

Pull Request Checklist

Testing

  • [x] Your PR passes all CI checks.
  • [x] Tests covering the positive and negative (error paths) are included.

Code Style and Documentation

positiveblue avatar Aug 07 '22 02:08 positiveblue

This test confirms everything in the link was ok, but the root issue was that we converted the warning to an error when sending to the link in the first place: https://github.com/lightningnetwork/lnd/issues/6801#issuecomment-1208254268

Roasbeef avatar Aug 08 '22 19:08 Roasbeef

@crypt-iq: review reminder @positiveblue, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Aug 15 '22 19:08 lightninglabs-deploy

needs rebase

Crypt-iQ avatar Aug 17 '22 15:08 Crypt-iQ

Close in favor of #6840

positiveblue avatar Aug 17 '22 23:08 positiveblue