lnd icon indicating copy to clipboard operation
lnd copied to clipboard

wtclient: Activate watchtower client by default and also add a Deactivate flag

Open priyanshiiit opened this issue 2 years ago • 1 comments

Change Description

Fixes: #5344

At present, the --wtclient.active has to be passed to enable the watchtower client but with this PR wtclient is automatically created, however, if not needed it could be disabled using --wtclient.deactivate flag.

priyanshiiit avatar Jul 14 '22 12:07 priyanshiiit

@priyanshiiit, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Sep 19 '22 16:09 lightninglabs-deploy

@priyanshiiit, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Nov 14 '22 20:11 lightninglabs-deploy

Something to note here is that if the wtclient is turned on by default without also adding a tower server, then this will cause a memory leak as backups will be queued in memory until a tower is registered. See https://github.com/lightningnetwork/lnd/issues/5983 and https://github.com/lightningnetwork/lnd/discussions/7286

This will be less of a problem when a fix for https://github.com/lightningnetwork/lnd/issues/5983 (a queue that overflows to disk) is implemented. But also we should probably warn the user that they need to add a tower for this flag to be of any use

ellemouton avatar Jan 09 '23 12:01 ellemouton

@priyanshiiit, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Jan 23 '23 14:01 lightninglabs-deploy

!lightninglabs-deploy mute

ellemouton avatar Jan 25 '23 06:01 ellemouton

Hi @priyanshiiit - I have muted this for now since it seems in-active and also given my previous comment. Feel free to unmute the bot once you are ready to hop back on

ellemouton avatar Jan 25 '23 06:01 ellemouton