lnd icon indicating copy to clipboard operation
lnd copied to clipboard

multi: send P2TR addrs by default for co-op close, add new `option_any_segwit` feature bit

Open Roasbeef opened this issue 3 years ago • 4 comments

In this commit, we implement the new option_any_segwit feature bit which enables us to start sending P2TR addresses for co-op closes as well as for upfront shutdown addresses. Along the way, we tighten up our validation a bit to only allow segwit v0 and v1 addresses.

Roasbeef avatar Jun 10 '22 18:06 Roasbeef

The refactoring I did in #6770 should make it easier to write unit tests for this change as well.

Roasbeef avatar Jul 27 '22 00:07 Roasbeef

@roasbeef, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Aug 03 '22 00:08 lightninglabs-deploy

Ok, I think this is g2g now: just pushed up fixes, a new unit test, and also an itest to make sure negotiation works e2e.

Roasbeef avatar Aug 05 '22 02:08 Roasbeef

Proper version should be pushed up now (w/o the commit that bumps the Go version).

Roasbeef avatar Aug 09 '22 01:08 Roasbeef