lnd Allow users to set custom lock duration in lockInputs

Allow users to set custom lock duration in lockInputs

Open kaloudis opened this issue 2 years ago • 3 comments

Related issue https://github.com/lightningnetwork/lnd/issues/5425

Pull Request Checklist

[x] Update lockInputs function
[x] Update RPC
[x] Update interface, swagger, and protobuf

Questions

Is seconds ideal? Should timelock be specified in minutes or other format instead?

Pull Request Checklist

[x] All changes are Go version 1.16 compliant
[ ] Your PR passes all CI checks. If a check cannot be passed for a justifiable reason, that reason must be stated in the commit message and PR description.
[ ] If this is your first time contributing, we recommend you read the Code Contribution Guidelines
- [ ] The code being submitted is commented according to Code Documentation and Commenting
- [ ] Commits have a logical structure according to Ideal Git Commit Structure
[ ] For new code: Code is accompanied by tests which exercise both the positive and negative (error paths) conditions (if applicable)
[ ] For bug fixes: If possible, code is accompanied by new tests which trigger the bug being fixed to prevent regressions
[ ] Any new logging statements use an appropriate subsystem and logging level
[ ] For code and documentation: lines are wrapped at 80 characters (the tab character should be counted as 8 characters, not 4, as some IDEs do per default)
[ ] A description of your changes should be added to running the release notes for the milestone your change will land in.

Nov 05 '21 20:11 kaloudis

Is seconds ideal? Should timelock be specified in minutes or other format instead?

I think seconds is reasonable. If we expose this on the CLI, then we can parse a duration (2h, 1d, etc) into a duration.

Apr 15 '22 23:04 Roasbeef

I'd be better off with the ability for FundPsbt to use externally locked utxos

Alternatively to specify this custom duration there as well?

Apr 15 '22 23:04 Roasbeef

@roasbeef: review reminder @kaloudis, remember to re-request review from reviewers when ready

Sep 19 '22 11:09 lightninglabs-deploy

@roasbeef: review reminder @kaloudis, remember to re-request review from reviewers when ready

Nov 14 '22 16:11 lightninglabs-deploy

I'd still be interested to find out the rationale for this change (see also https://github.com/lightningnetwork/lnd/pull/5935#discussion_r801330093), and whether it indeed puts development on track towards a FundPsbt call that is safe to use.