lightningnetwork
Add pagination options to listchaintxns
This PR adds pagination to listchaintxns. It prevents client application from out of memory when the number of transactions increases.
The new options are offset and limit.
Offset is the numer of transactions to skip.
Limit is max numer of transactions.
RPC also has same request field.
./lncli listchaintxns --offset=100 --limit=50
All merged transactions and unmerged transactions are sort by timestamp. I think sorting by timestamp is the best because it makes order invariable.
rebased.
lnrpc/gen_protos.sh made some difference.
@Roasbeef How can I execute test with travice?
@34ro Check if your account has been flagged on Travis. if it has you'll have to e-mail them to un-flag it :/
Looks like this essentially address https://github.com/lightningnetwork/lnd/issues/4719 right?
@mrfelton yep, though I think we may just need to remake this PR since it's so old, and we have a new internal pattern we use for adding pagination to existing RPCs.
@34ro, remember to re-request review from reviewers when ready
@34ro, remember to re-request review from reviewers when ready
I'll take a look at this given the latest request from a user: https://github.com/lightningnetwork/lnd/issues/4719#issuecomment-1447636264
@34ro, remember to re-request review from reviewers when ready