lnd icon indicating copy to clipboard operation
lnd copied to clipboard

multi: rename experimental endorsement signal to accountable

Open elnosh opened this issue 2 months ago • 3 comments

This PR renames bLIP4's experimental endorsement signal to accountable to match the latest proposal in https://github.com/lightning/blips/pull/67

elnosh avatar Nov 13 '25 16:11 elnosh

Summary of Changes

Hello @elnosh, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a comprehensive renaming of the experimental endorsement signal to accountable. This change is crucial for aligning the codebase with the latest BLIP-0004 proposal, ensuring that the terminology used for this experimental feature is consistent and up-to-date across all relevant components, including feature management, HTLC forwarding logic, configuration, and testing infrastructure.

Highlights

  • Terminology Update: The experimental endorsement signal has been renamed to accountable across the entire codebase to align with the latest BLIP-0004 proposal.
  • Configuration Alignment: Configuration options, feature bits, and command-line flags related to this experimental signal have been updated to reflect the new accountable terminology.
  • Codebase Consistency: All relevant function names, variable names, constants, and test cases have been refactored to use the accountable term, ensuring consistency throughout the project.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 13 '25 16:11 gemini-code-assist[bot]

@elnosh, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Dec 03 '25 22:12 lightninglabs-deploy

Approved the CI run.

Roasbeef avatar Dec 10 '25 02:12 Roasbeef