lightning-onion icon indicating copy to clipboard operation
lightning-onion copied to clipboard

Published 20 hours ago • verified publisher icon lightningnetwork

sphinx: remove unused nodeAddr

Open joostjager opened this issue 3 years ago • 3 comments

joostjager avatar Jul 12 '22 13:07 joostjager

Requesting review @Roasbeef

joostjager avatar Aug 25 '22 07:08 joostjager

I think this is a sane change, but it does end up breaking the API for all callers. As an intermediate step, we could just remove the internal field? Or is there some other motivation behind this change?

Roasbeef avatar Aug 29 '22 19:08 Roasbeef

The goal is to break up the API for all callers, so that the caller code can be simplified as well.

joostjager avatar Aug 30 '22 06:08 joostjager