taproot-assets icon indicating copy to clipboard operation
taproot-assets copied to clipboard

Add asset specifier

Open ffranr opened this issue 1 year ago • 4 comments

Closes https://github.com/lightninglabs/taproot-assets/issues/834

This PR introduces a new type named AssetSpecifier within the asset package. The AssetSpecifier type is designed to facilitate the conveyance of either an asset ID, an asset group public key, or both, throughout our codebase.

To demonstrate the utility of AssetSpecifier, this PR incorporates it in two key areas: coin selection and the derivation of tap commitment keys. While there are numerous potential applications for this new type across our project, this PR deliberately focuses on a select few to maintain brevity. The integration of AssetSpecifier sets the stage for future code contributions to leverage this type.

ffranr avatar Apr 02 '24 13:04 ffranr

!lightninglabs-deploy mute 720h00m

dstadulis avatar Apr 27 '24 09:04 dstadulis

what's the state / prio of this pr? (@dstadulis)

GeorgeTsagk avatar Apr 30 '24 13:04 GeorgeTsagk

low prio -- it's an enhancement that ffranr created to make asset specification easier, but isn't critical path for proof of concept

dstadulis avatar Apr 30 '24 16:04 dstadulis

@roasbeef: review reminder

lightninglabs-deploy avatar Jul 15 '24 10:07 lightninglabs-deploy