taproot-assets icon indicating copy to clipboard operation
taproot-assets copied to clipboard

BLIP update: RFQ wire messages

Open dstadulis opened this issue 1 year ago • 4 comments

TODO

  • [ ] https://github.com/Roasbeef/blips/pull/4

Merged

#845 #683 #792 #778

Cover the RFQ implementations in which some slight updates @ffranr to enumerate those updates in this issue

dstadulis avatar Mar 26 '24 18:03 dstadulis

The changes I think we should make to RFQ section of the tap BLIP can be found in these reviews that I've left on the tap BLIP PR:

https://github.com/lightning/blips/pull/29#pullrequestreview-1848901112 https://github.com/lightning/blips/pull/29#pullrequestreview-1853954713 https://github.com/lightning/blips/pull/29#pullrequestreview-1856677414 https://github.com/lightning/blips/pull/29#pullrequestreview-1856778322 https://github.com/lightning/blips/pull/29#pullrequestreview-1856784223 https://github.com/lightning/blips/pull/29#pullrequestreview-1856785907


Summary

I'll create PR(s) for the following RFQ section modifications:

  • Expiry field should be a Unix timestamp rather than a "number of seconds until expiry". https://github.com/Roasbeef/blips/pull/1
  • Add directionality field to the request message type. https://github.com/Roasbeef/blips/pull/2
  • Or, instead of a directionality field, we could specify both "in" and "out" assets: https://github.com/Roasbeef/blips/pull/3
  • Replace suggested_rate_tick field with BTC amount. (IMO, volume matters in a quote.)
  • Add optional error code and error message fields to the reject message type.

Other lower priority modifications:

  • Add an expiry Unix timestamp to the suggested BTC amount (currently: suggested_rate_tick) included in the request message.
  • Version fields? Or are we just going to bump the message type integer?
  • Add asset group key field to the request message type. This will allow us to setup a quote for any asset from the given asset group.
  • Other small fixes.

ffranr avatar Apr 03 '24 23:04 ffranr

Corresponding PR: https://github.com/Roasbeef/blips/pull/4

ffranr avatar Jul 24 '24 01:07 ffranr

Almost ready can be pulled out of draft soon @ffranr will apply some small changes

dstadulis avatar Jul 29 '24 15:07 dstadulis

In this issue, we are implementing the following changes:

  • Versioning support.
  • Introduction of fixed-point types for the in-asset and out-asset BTC fields.
  • Addition of a transfer_type field to the quote request message.
  • Expiry will now be represented as a Unix timestamp in seconds.
  • Removal of any references to rate ticks; we are now using fixed points.
  • The max_amount field in the quote request message is replaced by max_transferable_in_asset.

These changes follow the guidelines outlined in docs/rfq-and-decimal-display.md as detailed here: PR #1059.

ffranr avatar Sep 11 '24 18:09 ffranr