taproot-assets icon indicating copy to clipboard operation
taproot-assets copied to clipboard

Loadtesting metrics, updated

Open GeorgeTsagk opened this issue 2 years ago • 3 comments

Description

This PR is based on https://github.com/lightninglabs/taproot-assets/pull/662 by @calvinrzachman. It is an update / revisited version for our loadtesting setup and metrics collection.

GeorgeTsagk avatar Dec 13 '23 22:12 GeorgeTsagk

As discussed offline: We will not include client-side metrics for resource usage as that's not that insightful, since the main load is placed on the universe server

GeorgeTsagk avatar Jan 15 '24 16:01 GeorgeTsagk

With this in mind, I'm marking the PR as ready for review. We will add more sophisticated tracking in tapd's prometheus monitoring, not in the loadtesting code

GeorgeTsagk avatar Jul 30 '24 16:07 GeorgeTsagk

Closes https://github.com/lightninglabs/lightning-infra/issues/1455

GeorgeTsagk avatar Jul 30 '24 17:07 GeorgeTsagk

@georgetsagk, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Aug 28 '24 15:08 lightninglabs-deploy

Has some linter failures:

itest/loadtest/config.go:64: line is 102 characters (lll)
	Enabled bool   `long:"enabled" description:"Enable pushing metrics to Prometheus PushGateway"`
itest/loadtest/config.go:65: line is 86 characters (lll)
	Host    string `long:"host" description:"Prometheus PushGateway host address"`
itest/loadtest/config.go:110: line is 81 characters (lll)
	// PrometheusGateway is the configuration for the Prometheus PushGateway.
itest/loadtest/config.go:111: line is 161 characters (lll)
	PrometheusGateway *PrometheusGatewayConfig `group:"prometheus-gateway" namespace:"prometheus-gateway" description:"Prometheus PushGateway configuration"`
itest/loadtest/config.go:183: line is 83 characters (lll)
			return nil, fmt.Errorf("gateway hostname may not be empty")

Roasbeef avatar Sep 03 '24 18:09 Roasbeef

Pull Request Test Coverage Report for Build 10705406892

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.04%) to 40.139%

Changes Missing Coverage Covered Lines Changed/Added Lines %
itest/loadtest/config.go 0 22 0.0%
<!-- Total: 0 22
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
commitment/tap.go 4 83.91%
asset/asset.go 4 81.61%
tapdb/multiverse.go 7 60.32%
universe/interface.go 19 47.09%
<!-- Total: 36
Totals Coverage Status
Change from base Build 10628247677: -0.04%
Covered Lines: 23959
Relevant Lines: 59690

💛 - Coveralls

coveralls avatar Sep 04 '24 16:09 coveralls