taproot-assets
taproot-assets copied to clipboard
lightninglabs
multi: Add label to `PublishTransaction`
This PR chanegs the label used for Txs published to the network. Before, all Txs got the label tapd-asset-minting. Now, the label depends on the context. Currently we use two labels:
-
tapd-asset-minting -
tapd-asset-send
In the future we could even allow for more granular information being passed to the label.
Pull Request Test Coverage Report for Build 14731819540
Details
- 4 of 7 (57.14%) changed or added relevant lines in 5 files are covered.
- 54 unchanged lines in 8 files lost coverage.
- Overall coverage decreased (-0.04%) to 28.681%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| chain_bridge.go | 0 | 1 | 0.0% |
| itest/utils.go | 0 | 1 | 0.0% |
| tapfreighter/chain_porter.go | 0 | 1 | 0.0% |
| <!-- | Total: | 4 | 7 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| address/address.go | 2 | 67.47% |
| tappsbt/create.go | 2 | 26.74% |
| rfqmsg/records.go | 3 | 64.11% |
| tapgarden/caretaker.go | 3 | 68.59% |
| tapchannel/aux_leaf_signer.go | 5 | 43.08% |
| tapdb/multiverse.go | 6 | 53.03% |
| asset/mock.go | 8 | 63.84% |
| asset/asset.go | 25 | 47.67% |
| <!-- | Total: | 54 |
| Totals | |
|---|---|
| Change from base Build 14713241690: | -0.04% |
| Covered Lines: | 26702 |
| Relevant Lines: | 93101 |
💛 - Coveralls
@gijswijs, remember to re-request review from reviewers when ready
Can we go with one of the above ideas so we can merge this?
I've gone with:
tapd-asset-transfer
tapd-asset-issuance
I've also made the labels constants and rebased.
