taproot-assets icon indicating copy to clipboard operation
taproot-assets copied to clipboard

Published 20 hours ago • verified publisher icon lightninglabs

Align RFQ reject message with BLIP

Open ffranr opened this issue 1 year ago • 2 comments

This PR aligns the RFQ reject wire message with the BLIP changes found here https://github.com/Roasbeef/blips/pull/4 This PR is related to https://github.com/lightninglabs/taproot-assets/issues/871

These changes require a quote reject wire message version bump. We need to ensure that all RFQ breaking changes go into the same release. I've decided to spin them into their own PR because the scope of change is very narrow, these commits are small.

ffranr avatar Sep 20 '24 11:09 ffranr

Pull Request Test Coverage Report for Build 10958269291

Details

  • 36 of 50 (72.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 40.361%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rfqmsg/reject.go 36 50 72.0%
<!-- Total: 36 50
Files with Coverage Reduction New Missed Lines %
rfqmsg/reject.go 1 50.43%
tappsbt/create.go 2 53.22%
universe/interface.go 4 50.22%
<!-- Total: 7
Totals Coverage Status
Change from base Build 10958136063: -0.002%
Covered Lines: 24199
Relevant Lines: 59956
💛 - Coveralls

coveralls avatar Sep 20 '24 11:09 coveralls

I've changed this to draft to ensure this PR is merged with the rest of the RFQ breaking changes in the same release.

ffranr avatar Sep 23 '24 11:09 ffranr