neutrino icon indicating copy to clipboard operation
neutrino copied to clipboard

Published 20 hours ago • verified publisher icon lightninglabs

forAllOutboundPeers & forAllPeers

Open harshjv opened this issue 5 years ago • 2 comments

Was taking a look at the source code and found this: https://github.com/lightninglabs/neutrino/blob/e89b36762dd46f4e5c1fc8348b5582265f4a74ce/neutrino.go#L106-L121

Shouldn't forAllOutboundPeers only apply closure to ps.outboundPeers?

harshjv avatar Aug 23 '18 18:08 harshjv

All of neutrino’s peers are outbound at the moment. Persistent just means that we will retry a connection to that peer if we get disconnected.

cfromknecht avatar Aug 24 '18 23:08 cfromknecht

Naming could probably distinguish better, but I believe the behavior is correct

cfromknecht avatar Aug 24 '18 23:08 cfromknecht